fs: handle UV_ENOTDIR in fs.statSync with throwIfNoEntry provided

juanarbol · targos · commit 40f3a516bf8d · 2025-02-17T10:46:00.000+01:00
Fixes: #56993 Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com> PR-URL: #56996 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/src/node_file.cc b/src/node_file.cc
@@ -1088,6 +1088,10 @@ constexpr bool is_uv_error_except_no_entry(int result) {
   return result < 0 && result != UV_ENOENT;
 }
 
+constexpr bool is_uv_error_except_no_entry_dir(int result) {
+  return result < 0 && !(result == UV_ENOENT || result == UV_ENOTDIR);
+}
+
 static void Stat(const FunctionCallbackInfo<Value>& args) {
   Realm* realm = Realm::GetCurrent(args);
   BindingData* binding_data = realm->GetBindingData<BindingData>();
@@ -1121,8 +1125,11 @@ static void Stat(const FunctionCallbackInfo<Value>& args) {
     FS_SYNC_TRACE_BEGIN(stat);
     int result;
     if (do_not_throw_if_no_entry) {
-      result = SyncCallAndThrowIf(
-          is_uv_error_except_no_entry, env, &req_wrap_sync, uv_fs_stat, *path);
+      result = SyncCallAndThrowIf(is_uv_error_except_no_entry_dir,
+                                  env,
+                                  &req_wrap_sync,
+                                  uv_fs_stat,
+                                  *path);
     } else {
       result = SyncCallAndThrowOnError(env, &req_wrap_sync, uv_fs_stat, *path);
     }
diff --git a/test/parallel/test-fs-stat.js b/test/parallel/test-fs-stat.js
@@ -221,3 +221,8 @@ fs.lstat(__filename, undefined, common.mustCall());
     },
   );
 }
+
+{
+  // Test that the throwIfNoEntry option works and returns undefined
+  assert.ok(!(fs.statSync('./wont_exists', { throwIfNoEntry: false })));
+}

Original file line number	Diff line number	Diff line change
`@@ -221,3 +221,8 @@ fs.lstat(__filename, undefined, common.mustCall());`
`221`	`221`	`},`
`222`	`222`	`);`
`223`	`223`	`}`
	`224`	`+`
	`225`	`+{`
	`226`	`+ // Test that the throwIfNoEntry option works and returns undefined`
	`227`	`+ assert.ok(!(fs.statSync('./wont_exists', { throwIfNoEntry: false })));`
	`228`	`+}`