repl: close file descriptor of history file

joaocgreis · Trott · commit 3eea43af074e · 2019-08-10T19:21:33.000-07:00
PR-URL: #28858 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
diff --git a/lib/internal/repl/history.js b/lib/internal/repl/history.js
@@ -93,6 +93,7 @@ function setupHistory(repl, historyPath, ready) {
     fs.ftruncate(hnd, 0, (err) => {
       repl._historyHandle = hnd;
       repl.on('line', online);
+      repl.once('exit', onexit);
 
       // Reading the file data out erases it
       repl.once('flushHistory', function() {
@@ -137,6 +138,15 @@ function setupHistory(repl, historyPath, ready) {
       }
     }
   }
+
+  function onexit() {
+    if (repl._flushing) {
+      repl.once('flushHistory', onexit);
+      return;
+    }
+    repl.off('line', online);
+    fs.close(repl._historyHandle, () => {});
+  }
 }
 
 function _replHistoryMessage() {

Original file line number	Diff line number	Diff line change
`@@ -93,6 +93,7 @@ function setupHistory(repl, historyPath, ready) {`
`93`	`93`	`fs.ftruncate(hnd, 0, (err) => {`
`94`	`94`	`repl._historyHandle = hnd;`
`95`	`95`	`repl.on('line', online);`
	`96`	`+ repl.once('exit', onexit);`
`96`	`97`
`97`	`98`	`// Reading the file data out erases it`
`98`	`99`	`repl.once('flushHistory', function() {`
`@@ -137,6 +138,15 @@ function setupHistory(repl, historyPath, ready) {`
`137`	`138`	`}`
`138`	`139`	`}`
`139`	`140`	`}`
	`141`	`+`
	`142`	`+ function onexit() {`
	`143`	`+ if (repl._flushing) {`
	`144`	`+ repl.once('flushHistory', onexit);`
	`145`	`+ return;`
	`146`	`+ }`
	`147`	`+ repl.off('line', online);`
	`148`	`+ fs.close(repl._historyHandle, () => {});`
	`149`	`+ }`
`140`	`150`	`}`
`141`	`151`
`142`	`152`	`function _replHistoryMessage() {`