test: update test/parallel/test-http-pipe-fs.js to use countdown

chungngoops · gibfahn · commit 3ee4c1e14928 · 2017-12-20T00:03:16.000Z
PR-URL: #17346 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Anna Henningsen <anna@addaleax.net>
diff --git a/test/parallel/test-http-pipe-fs.js b/test/parallel/test-http-pipe-fs.js
@@ -3,6 +3,10 @@ const common = require('../common');
 const http = require('http');
 const fs = require('fs');
 const path = require('path');
+const Countdown = require('../common/countdown');
+const NUMBER_OF_STREAMS = 2;
+
+const countdown = new Countdown(NUMBER_OF_STREAMS, () => server.close());
 
 common.refreshTmpDir();
 
@@ -18,27 +22,23 @@ const server = http.createServer(common.mustCall(function(req, res) {
 }, 2)).listen(0, function() {
   http.globalAgent.maxSockets = 1;
 
-  for (let i = 0; i < 2; ++i) {
-    (function(i) {
-      const req = http.request({
-        port: server.address().port,
-        method: 'POST',
-        headers: {
-          'Content-Length': 5
-        }
-      }, function(res) {
-        res.on('end', function() {
-          console.error(`res${i} end`);
-          if (i === 2) {
-            server.close();
-          }
-        });
-        res.resume();
-      });
-      req.on('socket', function(s) {
-        console.error(`req${i} start`);
+  for (let i = 0; i < NUMBER_OF_STREAMS; ++i) {
+    const req = http.request({
+      port: server.address().port,
+      method: 'POST',
+      headers: {
+        'Content-Length': 5
+      }
+    }, function(res) {
+      res.on('end', function() {
+        console.error(`res${i + 1} end`);
+        countdown.dec();
       });
-      req.end('12345');
-    }(i + 1));
+      res.resume();
+    });
+    req.on('socket', function(s) {
+      console.error(`req${i + 1} start`);
+    });
+    req.end('12345');
   }
 });
