test: add missing newlines to repl .exit writes

dario-piotrowicz · RafaelGSS · commit 3d708e013255 · 2025-05-02T17:06:54.000-03:00
some tests write `.exit` into a repl server without including a newline character (`\n`), such commands are therefore simply not executed at all, the changes here add the missing newlines and as a side effect remove no longer necessary `end` calls PR-URL: #58041 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
diff --git a/test/parallel/test-repl-function-definition-edge-case.js b/test/parallel/test-repl-function-definition-edge-case.js
@@ -1,6 +1,6 @@
 // Reference: https://github.com/nodejs/node/pull/7624
 'use strict';
-require('../common');
+const common = require('../common');
 const assert = require('assert');
 const repl = require('repl');
 const stream = require('stream');
@@ -9,7 +9,8 @@ const r = initRepl();
 
 r.input.emit('data', 'function a() { return 42; } (1)\n');
 r.input.emit('data', 'a\n');
-r.input.emit('data', '.exit');
+r.input.emit('data', '.exit\n');
+r.once('exit', common.mustCall());
 
 const expected = '1\n[Function: a]\n';
 const got = r.output.accumulator.join('');
diff --git a/test/parallel/test-repl-import-referrer.js b/test/parallel/test-repl-import-referrer.js
@@ -23,5 +23,4 @@ child.on('exit', common.mustCall(() => {
 }));
 
 child.stdin.write('await import(\'./message.mjs\');\n');
-child.stdin.write('.exit');
-child.stdin.end();
+child.stdin.write('.exit\n');
diff --git a/test/parallel/test-repl-options.js b/test/parallel/test-repl-options.js
@@ -136,6 +136,5 @@ r4.close();
   child.stdin.write(
     'assert.ok(util.inspect(repl.repl, {depth: -1}).includes("REPLServer"));\n'
   );
-  child.stdin.write('.exit');
-  child.stdin.end();
+  child.stdin.write('.exit\n');
 }
diff --git a/test/parallel/test-repl-require-context.js b/test/parallel/test-repl-require-context.js
@@ -20,5 +20,4 @@ child.on('exit', common.mustCall(() => {
 child.stdin.write('const isObject = (obj) => obj.constructor === Object;\n');
 child.stdin.write('isObject({});\n');
 child.stdin.write(`require(${JSON.stringify(fixture)}).isObject({});\n`);
-child.stdin.write('.exit');
-child.stdin.end();
+child.stdin.write('.exit\n');
diff --git a/test/parallel/test-repl-require-self-referential.js b/test/parallel/test-repl-require-self-referential.js
@@ -23,5 +23,4 @@ child.on('exit', common.mustCall(() => {
 }));
 
 child.stdin.write('require("self_ref");\n');
-child.stdin.write('.exit');
-child.stdin.end();
+child.stdin.write('.exit\n');

Original file line number	Diff line number	Diff line change
`@@ -136,6 +136,5 @@ r4.close();`
`136`	`136`	`child.stdin.write(`
`137`	`137`	`'assert.ok(util.inspect(repl.repl, {depth: -1}).includes("REPLServer"));\n'`
`138`	`138`	`);`
`139`		`- child.stdin.write('.exit');`
`140`		`- child.stdin.end();`
	`139`	`+ child.stdin.write('.exit\n');`
`141`	`140`	`}`