test: refactor test-https-connect-localport

Trott · targos · commit 3cae010ea0c0 · 2019-03-27T22:16:18.000+01:00
Use arrow functions for callbacks. Replace uses of `this` with explicit variables. Add a trailing comma in a multiline object literal declaration. PR-URL: #26881 Fixes: #26862 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
diff --git a/test/sequential/test-https-connect-localport.js b/test/sequential/test-https-connect-localport.js
@@ -9,21 +9,23 @@ const https = require('https');
 const assert = require('assert');
 
 {
-  https.createServer({
+  const server = https.createServer({
     cert: fixtures.readKey('agent1-cert.pem'),
     key: fixtures.readKey('agent1-key.pem'),
-  }, common.mustCall(function(req, res) {
-    this.close();
+  }, common.mustCall((req, res) => {
+    server.close();
     res.end();
-  })).listen(0, 'localhost', common.mustCall(function() {
-    const port = this.address().port;
+  }));
+
+  server.listen(0, 'localhost', common.mustCall(() => {
+    const port = server.address().port;
     const req = https.get({
       host: 'localhost',
       pathname: '/',
       port,
       family: 4,
       localPort: common.PORT,
-      rejectUnauthorized: false
+      rejectUnauthorized: false,
     }, common.mustCall(() => {
       assert.strictEqual(req.socket.localPort, common.PORT);
       assert.strictEqual(req.socket.remotePort, port);
