http2: fix premature destroy

apapirovski · BethGriggs · commit 3c8c53f4f4c3 · 2018-10-17T00:07:24.000+01:00
Check stream._writableState.finished instead of stream.writable as the latter can lead to premature calls to destroy and dropped writes on busy processes. Backport-PR-URL: #22850 PR-URL: #21051 Fixes: #20750 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/lib/internal/http2/core.js b/lib/internal/http2/core.js
@@ -1892,7 +1892,7 @@ class Http2Stream extends Duplex {
     }
 
     // TODO(mcollina): remove usage of _*State properties
-    if (!this.writable) {
+    if (this._writableState.finished) {
       if (!this.readable && this.closed) {
         this.destroy();
         return;

Original file line number	Diff line number	Diff line change
`@@ -1892,7 +1892,7 @@ class Http2Stream extends Duplex {`
`1892`	`1892`	`}`
`1893`	`1893`
`1894`	`1894`	`// TODO(mcollina): remove usage of _*State properties`
`1895`		`- if (!this.writable) {`
	`1895`	`+ if (this._writableState.finished) {`
`1896`	`1896`	`if (!this.readable && this.closed) {`
`1897`	`1897`	`this.destroy();`
`1898`	`1898`	`return;`