src: fix size underflow in CallbackQueue

addaleax · addaleax · commit 39ca48c8401a · 2020-08-08T22:11:19.000+02:00
Only decrease the size when actually removing items. PR-URL: #34662 Fixes: #34657 Refs: #34572 Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/src/callback_queue-inl.h b/src/callback_queue-inl.h
@@ -22,8 +22,8 @@ CallbackQueue<R, Args...>::Shift() {
     head_ = ret->get_next();
     if (!head_)
       tail_ = nullptr;  // The queue is now empty.
+    size_--;
   }
-  size_--;
   return ret;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -22,8 +22,8 @@ CallbackQueue<R, Args...>::Shift() {`
`22`	`22`	`head_ = ret->get_next();`
`23`	`23`	`if (!head_)`
`24`	`24`	`tail_ = nullptr; // The queue is now empty.`
	`25`	`+ size_--;`
`25`	`26`	`}`
`26`		`- size_--;`
`27`	`27`	`return ret;`
`28`	`28`	`}`
`29`	`29`