http: expose host and protocol on ClientRequest

wenningplus · addaleax · commit 388d125a6447 · 2020-09-22T23:46:42.000+02:00
Allow host and protocol to be inspected. PR-URL: #33803 Fixes: #2461 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/doc/api/http.md b/doc/api/http.md
@@ -688,6 +688,27 @@ added: v0.4.0
 
 * {string} The request path.
 
+### `request.method`
+<!-- YAML
+added: v0.1.97
+-->
+
+* {string} The request method.
+
+### `request.host`
+<!-- YAML
+added: REPLACEME
+-->
+
+* {string} The request host.
+
+### `request.protocol`
+<!-- YAML
+added: REPLACEME
+-->
+
+* {string} The request protocol.
+
 ### `request.removeHeader(name)`
 <!-- YAML
 added: v1.6.0
diff --git a/lib/_http_client.js b/lib/_http_client.js
@@ -213,6 +213,8 @@ function ClientRequest(input, options, cb) {
   this.parser = null;
   this.maxHeadersCount = null;
   this.reusedSocket = false;
+  this.host = host;
+  this.protocol = protocol;
 
   let called = false;
 
diff --git a/test/parallel/test-http-outgoing-properties.js b/test/parallel/test-http-outgoing-properties.js
@@ -51,3 +51,26 @@ const OutgoingMessage = http.OutgoingMessage;
   msg.write('asd');
   assert.strictEqual(msg.writableLength, 7);
 }
+
+{
+  const server = http.createServer((req, res) => {
+    res.end();
+    server.close();
+  });
+
+  server.listen(0);
+
+  server.on('listening', common.mustCall(() => {
+    const req = http.request({
+      port: server.address().port,
+      method: 'GET',
+      path: '/'
+    });
+
+    assert.strictEqual(req.path, '/');
+    assert.strictEqual(req.method, 'GET');
+    assert.strictEqual(req.host, 'localhost');
+    assert.strictEqual(req.protocol, 'http:');
+    req.end();
+  }));
+}
