inspector: always set process.binding('inspector').callAndPauseOnStart

joyeecheung · targos · commit 3574b62717ec · 2019-03-27T22:16:22.000+01:00
Since `process.binding('inspector')` is loaded during bootstrap, simply set `process.binding('inspector').callAndPauseOnStart` unconditionally instead of relying on `agent->WillWaitForConnect()` which depends on runtime states, PR-URL: #26793 Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
diff --git a/src/inspector_js_api.cc b/src/inspector_js_api.cc
@@ -271,8 +271,6 @@ void Initialize(Local<Object> target, Local<Value> unused,
                 Local<Context> context, void* priv) {
   Environment* env = Environment::GetCurrent(context);
 
-  Agent* agent = env->inspector_agent();
-
   v8::Local<v8::Function> consoleCallFunc =
       env->NewFunctionTemplate(InspectorConsoleCall, v8::Local<v8::Signature>(),
                                v8::ConstructorBehavior::kThrow,
@@ -285,8 +283,7 @@ void Initialize(Local<Object> target, Local<Value> unused,
 
   env->SetMethod(
       target, "setConsoleExtensionInstaller", SetConsoleExtensionInstaller);
-  if (agent->WillWaitForConnect())
-    env->SetMethod(target, "callAndPauseOnStart", CallAndPauseOnStart);
+  env->SetMethod(target, "callAndPauseOnStart", CallAndPauseOnStart);
   env->SetMethod(target, "open", Open);
   env->SetMethodNoSideEffect(target, "url", Url);
 
