perf_hooks: reuse buffer for uv metrics · nodejs/node@32401c2 · GitHub
Skip to content

Commit 32401c2

Browse files
HoonDongKangaduh95
HoonDongKang
authored and
aduh95
committed
perf_hooks: reuse buffer for uv metrics
Reuse an aliased Int32Array to transfer uv metrics from C++ to JavaScript instead of allocating a new V8 array on every access. Assisted-by: Codex Signed-off-by: HoonDongKang <d159123@naver.com> PR-URL: #65985 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
1 parent 5496943 commit 32401c2

6 files changed

Lines changed: 46 additions & 17 deletions

File tree

‎lib/internal/perf/nodetiming.js‎

Lines changed: 5 additions & 4 deletions

‎src/node_perf.cc‎

Lines changed: 24 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
namespace node {
1515
namespace performance {
1616

17-
using v8::Array;
1817
using v8::Context;
1918
using v8::DontDelete;
2019
using v8::Function;
@@ -57,7 +56,12 @@ PerformanceState::PerformanceState(Isolate* isolate,
5756
offsetof(performance_state_internal, observers),
5857
NODE_PERFORMANCE_ENTRY_TYPE_INVALID,
5958
root,
60-
MAYBE_FIELD_PTR(info, observers)) {
59+
MAYBE_FIELD_PTR(info, observers)),
60+
uv_metrics(isolate,
61+
offsetof(performance_state_internal, uv_metrics),
62+
3,
63+
root,
64+
MAYBE_FIELD_PTR(info, uv_metrics)) {
6165
if (info == nullptr) {
6266
// For performance states initialized from scratch, reset
6367
// all the milestones and initialize the time origin.
@@ -81,9 +85,15 @@ PerformanceState::SerializeInfo PerformanceState::Serialize(
8185
// We'll re-initialize them after deserialization.
8286
ResetMilestones();
8387

88+
// Do not retain runtime metrics in the snapshot.
89+
for (size_t i = 0; i < uv_metrics.Length(); ++i) {
90+
uv_metrics[i] = 0;
91+
}
92+
8493
SerializeInfo info{root.Serialize(context, creator),
8594
milestones.Serialize(context, creator),
86-
observers.Serialize(context, creator)};
95+
observers.Serialize(context, creator),
96+
uv_metrics.Serialize(context, creator)};
8797
return info;
8898
}
8999

@@ -105,6 +115,7 @@ void PerformanceState::Deserialize(v8::Local<v8::Context> context,
105115
root.Deserialize(context);
106116
milestones.Deserialize(context);
107117
observers.Deserialize(context);
118+
uv_metrics.Deserialize(context);
108119

109120
// Re-initialize the time origin and timestamp i.e. the process start time.
110121
Initialize(time_origin, time_origin_timestamp);
@@ -116,6 +127,7 @@ std::ostream& operator<<(std::ostream& o,
116127
<< " " << i.root << ", // root\n"
117128
<< " " << i.milestones << ", // milestones\n"
118129
<< " " << i.observers << ", // observers\n"
130+
<< " " << i.uv_metrics << ", // uv_metrics\n"
119131
<< "}";
120132
return o;
121133
}
@@ -265,17 +277,13 @@ void LoopIdleTime(const FunctionCallbackInfo<Value>& args) {
265277

266278
void UvMetricsInfo(const FunctionCallbackInfo<Value>& args) {
267279
Environment* env = Environment::GetCurrent(args);
268-
Isolate* isolate = env->isolate();
269280
uv_metrics_t metrics;
270281
// uv_metrics_info always return 0
271282
CHECK_EQ(uv_metrics_info(env->event_loop(), &metrics), 0);
272-
Local<Value> data[] = {
273-
Integer::New(isolate, metrics.loop_count),
274-
Integer::New(isolate, metrics.events),
275-
Integer::New(isolate, metrics.events_waiting),
276-
};
277-
Local<Array> arr = Array::New(env->isolate(), data, arraysize(data));
278-
args.GetReturnValue().Set(arr);
283+
AliasedInt32Array& buffer = env->performance_state()->uv_metrics;
284+
buffer[0] = static_cast<int32_t>(metrics.loop_count);
285+
buffer[1] = static_cast<int32_t>(metrics.events);
286+
buffer[2] = static_cast<int32_t>(metrics.events_waiting);
279287
}
280288

281289
void CreateELDHistogram(const FunctionCallbackInfo<Value>& args) {
@@ -366,6 +374,11 @@ void CreatePerContextProperties(Local<Object> target,
366374
target->Set(context,
367375
FIXED_ONE_BYTE_STRING(isolate, "milestones"),
368376
state->milestones.GetJSArray()).Check();
377+
target
378+
->Set(context,
379+
FIXED_ONE_BYTE_STRING(isolate, "uvMetricsBuffer"),
380+
state->uv_metrics.GetJSArray())
381+
.Check();
369382

370383
Local<Object> constants = Object::New(isolate);
371384

‎src/node_perf_common.h‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,7 @@ class PerformanceState {
6262
AliasedBufferIndex root;
6363
AliasedBufferIndex milestones;
6464
AliasedBufferIndex observers;
65+
AliasedBufferIndex uv_metrics;
6566
};
6667

6768
explicit PerformanceState(v8::Isolate* isolate,
@@ -78,6 +79,7 @@ class PerformanceState {
7879
AliasedUint8Array root;
7980
AliasedFloat64Array milestones;
8081
AliasedUint32Array observers;
82+
AliasedInt32Array uv_metrics;
8183

8284
uint64_t performance_last_gc_start_mark = 0;
8385
uint16_t current_gc_type = 0;
@@ -92,6 +94,7 @@ class PerformanceState {
9294
// doubles first so that they are always sizeof(double)-aligned
9395
double milestones[NODE_PERFORMANCE_MILESTONE_INVALID];
9496
uint32_t observers[NODE_PERFORMANCE_ENTRY_TYPE_INVALID];
97+
int32_t uv_metrics[3];
9598
};
9699
};
97100

‎src/node_snapshotable.cc‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -406,6 +406,7 @@ size_t SnapshotSerializer::Write(const ImmediateInfo::SerializeInfo& data) {
406406
// [ 4/8 bytes ] snapshot index of root
407407
// [ 4/8 bytes ] snapshot index of milestones
408408
// [ 4/8 bytes ] snapshot index of observers
409+
// [ 4/8 bytes ] snapshot index of uv_metrics
409410
template <>
410411
performance::PerformanceState::SerializeInfo SnapshotDeserializer::Read() {
411412
Debug("Read<PerformanceState::SerializeInfo>()\n");
@@ -414,6 +415,7 @@ performance::PerformanceState::SerializeInfo SnapshotDeserializer::Read() {
414415
result.root = ReadArithmetic<AliasedBufferIndex>();
415416
result.milestones = ReadArithmetic<AliasedBufferIndex>();
416417
result.observers = ReadArithmetic<AliasedBufferIndex>();
418+
result.uv_metrics = ReadArithmetic<AliasedBufferIndex>();
417419
if (is_debug) {
418420
std::string str = ToStr(result);
419421
Debug("Read<PerformanceState::SerializeInfo>() %s\n", str);
@@ -432,6 +434,7 @@ size_t SnapshotSerializer::Write(
432434
size_t written_total = WriteArithmetic<AliasedBufferIndex>(data.root);
433435
written_total += WriteArithmetic<AliasedBufferIndex>(data.milestones);
434436
written_total += WriteArithmetic<AliasedBufferIndex>(data.observers);
437+
written_total += WriteArithmetic<AliasedBufferIndex>(data.uv_metrics);
435438

436439
Debug("Write<PerformanceState::SerializeInfo>() wrote %d bytes\n",
437440
written_total);

‎test/fixtures/test-nodetiming-uvmetricsinfo.js‎

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,15 @@ function safeMetricsInfo(cb) {
4040
fs.open(__filename, 'r', (err) => {
4141
assert.ifError(err);
4242
});
43+
44+
const saved = { ...info };
45+
safeMetricsInfo((nextInfo) => {
46+
assert.notStrictEqual(nextInfo, info);
47+
assert.ok(nextInfo.loopCount > saved.loopCount);
48+
// Updating the shared buffer must not change earlier results.
49+
assert.deepStrictEqual(info, saved);
50+
});
4351
}
4452

4553
safeMetricsInfo(openFile);
46-
}
54+
}

‎typings/internalBinding/performance.d.ts‎

Lines changed: 2 additions & 1 deletion

0 commit comments

Comments
 (0)