inspector: fixed V8InspectorClient::currentTimeMS

alexkozy · targos · commit 311ec127024e · 2018-08-02T22:10:07.000+02:00
On inspector side inside V8 we assume that this method should return number of ms since epoch. PR-URL: #21917 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
diff --git a/src/inspector_agent.cc b/src/inspector_agent.cc
@@ -187,8 +187,6 @@ static int StartDebugSignalHandler() {
 #endif  // _WIN32
 
 
-// Used in NodeInspectorClient::currentTimeMS() below.
-const int NANOS_PER_MSEC = 1000000;
 const int CONTEXT_GROUP_ID = 1;
 
 class ChannelImpl final : public v8_inspector::V8Inspector::Channel,
@@ -593,7 +591,7 @@ class NodeInspectorClient : public V8InspectorClient {
   }
 
   double currentTimeMS() override {
-    return uv_hrtime() * 1.0 / NANOS_PER_MSEC;
+    return env_->isolate_data()->platform()->CurrentClockTimeMillis();
   }
 
   node::Environment* env_;

Original file line number	Diff line number	Diff line change
`@@ -187,8 +187,6 @@ static int StartDebugSignalHandler() {`
`187`	`187`	`#endif // _WIN32`
`188`	`188`
`189`	`189`
`190`		`-// Used in NodeInspectorClient::currentTimeMS() below.`
`191`		`-const int NANOS_PER_MSEC = 1000000;`
`192`	`190`	`const int CONTEXT_GROUP_ID = 1;`
`193`	`191`
`194`	`192`	`class ChannelImpl final : public v8_inspector::V8Inspector::Channel,`
`@@ -593,7 +591,7 @@ class NodeInspectorClient : public V8InspectorClient {`
`593`	`591`	`}`
`594`	`592`
`595`	`593`	`double currentTimeMS() override {`
`596`		`- return uv_hrtime() * 1.0 / NANOS_PER_MSEC;`
	`594`	`+ return env_->isolate_data()->platform()->CurrentClockTimeMillis();`
`597`	`595`	`}`
`598`	`596`
`599`	`597`	`node::Environment* env_;`