test: update test-domain-uncaught-exception.js

amazingandyyy · MylesBorins · commit 308cead66e1c · 2016-12-14T22:53:08.000-05:00
file: test/parallel/test-domain-uncaught-exception.js 1. There are three setTimeout() in the file and they do not specify a duration (the second argument), so I change them to setImmediate() instead. 2. There are four callbacks that take an argument called `err` but that argument is never used, so I removed them. PR-URL: #10193 Reviewed-By: Sam Roberts <sam@strongloop.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
diff --git a/test/parallel/test-domain-uncaught-exception.js b/test/parallel/test-domain-uncaught-exception.js
@@ -25,7 +25,7 @@ function test1() {
   d.run(function() {
     setTimeout(function onTimeout() {
       throw new Error('boom!');
-    });
+    }, 1);
   });
 }
 
@@ -59,7 +59,7 @@ function test3() {
   const d3 = domain.create();
   const d4 = domain.create();
 
-  d3.on('error', function onErrorInD3Domain(err) {
+  d3.on('error', function onErrorInD3Domain() {
     process.send('errorHandledByDomain');
   });
 
@@ -88,15 +88,15 @@ function test4() {
   const d5 = domain.create();
   const d6 = domain.create();
 
-  d5.on('error', function onErrorInD2Domain(err) {
+  d5.on('error', function onErrorInD2Domain() {
     process.send('errorHandledByDomain');
   });
 
   d5.run(function() {
     d6.run(function() {
       setTimeout(function onTimeout() {
         throw new Error('boom!');
-      });
+      }, 1);
     });
   });
 }
@@ -115,7 +115,7 @@ function test5() {
   const d7 = domain.create();
   const d8 = domain.create();
 
-  d8.on('error', function onErrorInD3Domain(err) {
+  d8.on('error', function onErrorInD3Domain() {
     process.send('errorHandledByDomain');
   });
 
@@ -139,15 +139,15 @@ function test6() {
   const d9 = domain.create();
   const d10 = domain.create();
 
-  d10.on('error', function onErrorInD2Domain(err) {
+  d10.on('error', function onErrorInD2Domain() {
     process.send('errorHandledByDomain');
   });
 
   d9.run(function() {
     d10.run(function() {
       setTimeout(function onTimeout() {
         throw new Error('boom!');
-      });
+      }, 1);
     });
   });
 }
