timers: check for immediate instance in clearImmediate

gurgunday · RafaelGSS · commit 2cbf3c38dbda · 2025-05-02T17:04:42.000-03:00
PR-URL: #57069 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
diff --git a/lib/timers.js b/lib/timers.js
@@ -301,7 +301,7 @@ ObjectDefineProperty(setImmediate, customPromisify, {
  * @returns {void}
  */
 function clearImmediate(immediate) {
-  if (!immediate || immediate._destroyed)
+  if (!immediate?._onImmediate || immediate._destroyed)
     return;
 
   immediateInfo[kCount]--;
diff --git a/test/parallel/test-timers-invalid-clear.js b/test/parallel/test-timers-invalid-clear.js
@@ -0,0 +1,13 @@
+'use strict';
+
+const common = require('../common');
+
+// clearImmediate should be a noop if anything other than an Immediate
+// is passed to it.
+
+const t = setTimeout(common.mustCall());
+
+clearImmediate(t);
+
+setTimeout(common.mustCall());
+setTimeout(common.mustCall());
