test: do not load absolute path crypto engines twice

richardlau · richardlau · commit 2c84c3eee80b · 2022-01-17T07:51:11.000-05:00
Newer versions of OpenSSL now throws an error if an engine is loaded twice by its absolute path (a second load by its id appears to be okay). PR-URL: #41175 Refs: quictls/openssl#68 Refs: https://mta.openssl.org/pipermail/openssl-announce/2021-December/000212.html Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Michael Dawson <midawson@redhat.com>
diff --git a/test/parallel/test-crypto-engine.js b/test/parallel/test-crypto-engine.js
@@ -44,10 +44,13 @@ crypto.setEngine('dynamic', crypto.constants.ENGINE_METHOD_RSA);
     fs.accessSync(enginePath);
 
     crypto.setEngine(enginePath);
-    crypto.setEngine(enginePath);
+    // OpenSSL 3.0.1 and 1.1.1m now throw errors if an engine is loaded again
+    // with a duplicate absolute path.
+    // TODO(richardlau): figure out why this fails on macOS but not Linux.
+    // crypto.setEngine(enginePath);
 
-    crypto.setEngine(enginePath, crypto.constants.ENGINE_METHOD_RSA);
-    crypto.setEngine(enginePath, crypto.constants.ENGINE_METHOD_RSA);
+    // crypto.setEngine(enginePath, crypto.constants.ENGINE_METHOD_RSA);
+    // crypto.setEngine(enginePath, crypto.constants.ENGINE_METHOD_RSA);
 
     process.env.OPENSSL_ENGINES = execDir;
 
