lib: use kEmptyObject as default value for options

deokjinkim · RafaelGSS · commit 28f9089b83bd · 2023-01-05T13:11:42.000-03:00
`kEmptyObject` is more suitable than {} if options don't need mutation. PR-URL: #46011 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/lib/events.js b/lib/events.js
@@ -1002,8 +1002,9 @@ function eventTargetAgnosticAddListener(emitter, name, listener, flags) {
  * @param {{ signal: AbortSignal; }} [options]
  * @returns {AsyncIterator}
  */
-function on(emitter, event, options) {
-  const signal = options?.signal;
+function on(emitter, event, options = kEmptyObject) {
+  // Parameters validation
+  const signal = options.signal;
   validateAbortSignal(signal, 'options.signal');
   if (signal?.aborted)
     throw new AbortError(undefined, { cause: signal?.reason });
diff --git a/lib/internal/fs/watchers.js b/lib/internal/fs/watchers.js
@@ -14,7 +14,10 @@ const {
     ERR_INVALID_ARG_VALUE,
   },
 } = require('internal/errors');
-const { createDeferredPromise } = require('internal/util');
+const {
+  createDeferredPromise,
+  kEmptyObject,
+} = require('internal/util');
 
 const {
   kFsStatsFieldsNumber,
@@ -296,7 +299,7 @@ ObjectDefineProperty(FSEvent.prototype, 'owner', {
   set(v) { return this[owner_symbol] = v; }
 });
 
-async function* watch(filename, options = {}) {
+async function* watch(filename, options = kEmptyObject) {
   const path = toNamespacedPath(getValidatedPath(filename));
   validateObject(options, 'options');
 
diff --git a/lib/internal/http2/core.js b/lib/internal/http2/core.js
@@ -3326,7 +3326,7 @@ function createSecureServer(options, handler) {
 function createServer(options, handler) {
   if (typeof options === 'function') {
     handler = options;
-    options = {};
+    options = kEmptyObject;
   }
   return new Http2Server(options, handler);
 }
diff --git a/lib/internal/socketaddress.js b/lib/internal/socketaddress.js
@@ -26,6 +26,7 @@ const {
 
 const {
   customInspectSymbol: kInspect,
+  kEmptyObject,
 } = require('internal/util');
 
 const { inspect } = require('internal/util/inspect');
@@ -44,7 +45,7 @@ class SocketAddress extends JSTransferable {
     return value?.[kHandle] !== undefined;
   }
 
-  constructor(options = {}) {
+  constructor(options = kEmptyObject) {
     super();
     validateObject(options, 'options');
     let { family = 'ipv4' } = options;
diff --git a/lib/net.js b/lib/net.js
@@ -108,6 +108,7 @@ const {
 } = require('internal/errors');
 const { isUint8Array } = require('internal/util/types');
 const { queueMicrotask } = require('internal/process/task_queues');
+const { kEmptyObject } = require('internal/util');
 const {
   validateAbortSignal,
   validateBoolean,
@@ -1584,7 +1585,7 @@ function Server(options, connectionListener) {
 
   if (typeof options === 'function') {
     connectionListener = options;
-    options = {};
+    options = kEmptyObject;
     this.on('connection', connectionListener);
   } else if (options == null || typeof options === 'object') {
     options = { ...options };

Original file line number	Diff line number	Diff line change
`@@ -3326,7 +3326,7 @@ function createSecureServer(options, handler) {`
`3326`	`3326`	`function createServer(options, handler) {`
`3327`	`3327`	`if (typeof options === 'function') {`
`3328`	`3328`	`handler = options;`
`3329`		`- options = {};`
	`3329`	`+ options = kEmptyObject;`
`3330`	`3330`	`}`
`3331`	`3331`	`return new Http2Server(options, handler);`
`3332`	`3332`	`}`