tools: improve docopen target in Makefile · nodejs/node@232026d · GitHub
Skip to content

Commit 232026d

Browse files
thefourtheyeMylesBorins
authored andcommitted
tools: improve docopen target in Makefile
1. As it is, it just tries to build only the `all.html` file. If none of the other files are built already, generated page will not be good. To fix this, we process the assets and generate HTML files first. 2. After the HTML is generated, `google-chrome` is used to open the generated file in browser. This is not very portable as it might not be installed or installations might have used a different name. So, we use Python's webbrowser module to open the file. PR-URL: #9436 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
1 parent d283704 commit 232026d

1 file changed

Lines changed: 5 additions & 6 deletions

File tree

Makefile

Lines changed: 5 additions & 6 deletions

0 commit comments

Comments
 (0)