worker: throw InvalidStateError in postMessage after close

Nahee-Park · marco-ippolito · commit 226836c5acf4 · 2024-11-17T11:51:43.000+01:00
This update addresses expected failures for invalid postMessage after close in WPT. PR-URL: #55206 Reviewed-By: Mattias Buelens <mattias@buelens.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
diff --git a/lib/internal/worker/io.js b/lib/internal/worker/io.js
@@ -491,7 +491,7 @@ class BroadcastChannel extends EventTarget {
     if (arguments.length === 0)
       throw new ERR_MISSING_ARGS('message');
     if (this[kHandle] === undefined)
-      throw new DOMException('BroadcastChannel is closed.');
+      throw new DOMException('BroadcastChannel is closed.', 'InvalidStateError');
     if (this[kHandle].postMessage(message) === undefined)
       throw new DOMException('Message could not be posted.');
   }
diff --git a/test/wpt/status/webmessaging/broadcastchannel.json b/test/wpt/status/webmessaging/broadcastchannel.json
@@ -10,14 +10,6 @@
       ]
     }
   },
-  "interface.any.js": {
-    "fail": {
-      "expected": [
-        "postMessage after close should throw",
-        "postMessage should throw InvalidStateError after close, even with uncloneable data"
-      ]
-    }
-  },
   "origin.window.js": {
     "fail": {
       "expected": [

Original file line number	Diff line number	Diff line change
`@@ -491,7 +491,7 @@ class BroadcastChannel extends EventTarget {`
`491`	`491`	`if (arguments.length === 0)`
`492`	`492`	`throw new ERR_MISSING_ARGS('message');`
`493`	`493`	`if (this[kHandle] === undefined)`
`494`		`- throw new DOMException('BroadcastChannel is closed.');`
	`494`	`+ throw new DOMException('BroadcastChannel is closed.', 'InvalidStateError');`
`495`	`495`	`if (this[kHandle].postMessage(message) === undefined)`
`496`	`496`	`throw new DOMException('Message could not be posted.');`
`497`	`497`	`}`