test_runner: remove plan option from run()

cjihrig · marco-ippolito · commit 206c668ee7b8 · 2024-08-19T10:32:38.000+02:00
This commit removes the plan option to run(). I believe it was added by mistake. It is not documented, untested, and a test plan does not make sense in the context of run(). This commit also fixes a minor formatting issue in a related fixture. Refs: #52860 PR-URL: #53834 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
diff --git a/lib/internal/test_runner/runner.js b/lib/internal/test_runner/runner.js
@@ -524,7 +524,6 @@ function run(options) {
     watch,
     setup,
     only,
-    plan,
   } = options;
 
   if (files != null) {
@@ -577,7 +576,7 @@ function run(options) {
     });
   }
 
-  const root = createTestTree({ __proto__: null, concurrency, timeout, signal, plan });
+  const root = createTestTree({ __proto__: null, concurrency, timeout, signal });
   root.harness.shouldColorizeTestFiles ||= shouldColorizeTestFiles(root);
 
   if (process.env.NODE_TEST_CONTEXT !== undefined) {
diff --git a/test/fixtures/test-runner/output/test-runner-plan.js b/test/fixtures/test-runner/output/test-runner-plan.js
@@ -74,6 +74,6 @@ test('planning with streams', (t, done) => {
   });
 
   stream.on('end', () => {
-   done();
+    done();
   });
 })

-Original file line number
+Diff line change
   });
   stream.on('end', () => {
 -   done();
 +    done();
   });
 })