lib: rename `validateInternalField` into `validateThisInternalField` · nodejs/node@20089e2 · GitHub
Skip to content

Commit 20089e2

Browse files
LiviaMedeirosRafaelGSS
authored andcommitted
lib: rename validateInternalField into validateThisInternalField
PR-URL: #58765 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 7498383 commit 20089e2

8 files changed

Lines changed: 70 additions & 70 deletions

File tree

lib/internal/event_target.js

Lines changed: 3 additions & 3 deletions

lib/internal/perf/observe.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ const {
5252
const {
5353
validateFunction,
5454
validateObject,
55-
validateInternalField,
55+
validateThisInternalField,
5656
} = require('internal/validators');
5757

5858
const {
@@ -185,12 +185,12 @@ class PerformanceObserverEntryList {
185185
}
186186

187187
getEntries() {
188-
validateInternalField(this, kBuffer, 'PerformanceObserverEntryList');
188+
validateThisInternalField(this, kBuffer, 'PerformanceObserverEntryList');
189189
return ArrayPrototypeSlice(this[kBuffer]);
190190
}
191191

192192
getEntriesByType(type) {
193-
validateInternalField(this, kBuffer, 'PerformanceObserverEntryList');
193+
validateThisInternalField(this, kBuffer, 'PerformanceObserverEntryList');
194194
if (arguments.length === 0) {
195195
throw new ERR_MISSING_ARGS('type');
196196
}
@@ -201,7 +201,7 @@ class PerformanceObserverEntryList {
201201
}
202202

203203
getEntriesByName(name, type = undefined) {
204-
validateInternalField(this, kBuffer, 'PerformanceObserverEntryList');
204+
validateThisInternalField(this, kBuffer, 'PerformanceObserverEntryList');
205205
if (arguments.length === 0) {
206206
throw new ERR_MISSING_ARGS('name');
207207
}

lib/internal/perf/performance.js

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ const nodeTiming = require('internal/perf/nodetiming');
4343
const timerify = require('internal/perf/timerify');
4444
const { customInspectSymbol: kInspect, kEnumerableProperty, kEmptyObject } = require('internal/util');
4545
const { inspect } = require('util');
46-
const { validateInternalField } = require('internal/validators');
46+
const { validateThisInternalField } = require('internal/validators');
4747
const { convertToInt } = require('internal/webidl');
4848

4949
const kPerformanceBrand = Symbol('performance');
@@ -68,7 +68,7 @@ class Performance extends EventTarget {
6868
}
6969

7070
clearMarks(name = undefined) {
71-
validateInternalField(this, kPerformanceBrand, 'Performance');
71+
validateThisInternalField(this, kPerformanceBrand, 'Performance');
7272
if (name !== undefined) {
7373
name = `${name}`;
7474
}
@@ -77,28 +77,28 @@ class Performance extends EventTarget {
7777
}
7878

7979
clearMeasures(name = undefined) {
80-
validateInternalField(this, kPerformanceBrand, 'Performance');
80+
validateThisInternalField(this, kPerformanceBrand, 'Performance');
8181
if (name !== undefined) {
8282
name = `${name}`;
8383
}
8484
clearEntriesFromBuffer('measure', name);
8585
}
8686

8787
clearResourceTimings(name = undefined) {
88-
validateInternalField(this, kPerformanceBrand, 'Performance');
88+
validateThisInternalField(this, kPerformanceBrand, 'Performance');
8989
if (name !== undefined) {
9090
name = `${name}`;
9191
}
9292
clearEntriesFromBuffer('resource', name);
9393
}
9494

9595
getEntries() {
96-
validateInternalField(this, kPerformanceBrand, 'Performance');
96+
validateThisInternalField(this, kPerformanceBrand, 'Performance');
9797
return filterBufferMapByNameAndType();
9898
}
9999

100100
getEntriesByName(name, type = undefined) {
101-
validateInternalField(this, kPerformanceBrand, 'Performance');
101+
validateThisInternalField(this, kPerformanceBrand, 'Performance');
102102
if (arguments.length === 0) {
103103
throw new ERR_MISSING_ARGS('name');
104104
}
@@ -110,7 +110,7 @@ class Performance extends EventTarget {
110110
}
111111

112112
getEntriesByType(type) {
113-
validateInternalField(this, kPerformanceBrand, 'Performance');
113+
validateThisInternalField(this, kPerformanceBrand, 'Performance');
114114
if (arguments.length === 0) {
115115
throw new ERR_MISSING_ARGS('type');
116116
}
@@ -119,28 +119,28 @@ class Performance extends EventTarget {
119119
}
120120

121121
mark(name, options = kEmptyObject) {
122-
validateInternalField(this, kPerformanceBrand, 'Performance');
122+
validateThisInternalField(this, kPerformanceBrand, 'Performance');
123123
if (arguments.length === 0) {
124124
throw new ERR_MISSING_ARGS('name');
125125
}
126126
return mark(name, options);
127127
}
128128

129129
measure(name, startOrMeasureOptions = kEmptyObject, endMark = undefined) {
130-
validateInternalField(this, kPerformanceBrand, 'Performance');
130+
validateThisInternalField(this, kPerformanceBrand, 'Performance');
131131
if (arguments.length === 0) {
132132
throw new ERR_MISSING_ARGS('name');
133133
}
134134
return measure(name, startOrMeasureOptions, endMark);
135135
}
136136

137137
now() {
138-
validateInternalField(this, kPerformanceBrand, 'Performance');
138+
validateThisInternalField(this, kPerformanceBrand, 'Performance');
139139
return now();
140140
}
141141

142142
setResourceTimingBufferSize(maxSize) {
143-
validateInternalField(this, kPerformanceBrand, 'Performance');
143+
validateThisInternalField(this, kPerformanceBrand, 'Performance');
144144
if (arguments.length === 0) {
145145
throw new ERR_MISSING_ARGS('maxSize');
146146
}
@@ -150,12 +150,12 @@ class Performance extends EventTarget {
150150
}
151151

152152
get timeOrigin() {
153-
validateInternalField(this, kPerformanceBrand, 'Performance');
153+
validateThisInternalField(this, kPerformanceBrand, 'Performance');
154154
return getTimeOriginTimestamp();
155155
}
156156

157157
toJSON() {
158-
validateInternalField(this, kPerformanceBrand, 'Performance');
158+
validateThisInternalField(this, kPerformanceBrand, 'Performance');
159159
return {
160160
nodeTiming: this.nodeTiming,
161161
timeOrigin: this.timeOrigin,

lib/internal/perf/performance_entry.js

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ const {
1515
customInspectSymbol: kInspect,
1616
kEnumerableProperty,
1717
} = require('internal/util');
18-
const { validateInternalField } = require('internal/validators');
18+
const { validateThisInternalField } = require('internal/validators');
1919

2020
const { inspect } = require('util');
2121

@@ -49,22 +49,22 @@ class PerformanceEntry {
4949
}
5050

5151
get name() {
52-
validateInternalField(this, kName, 'PerformanceEntry');
52+
validateThisInternalField(this, kName, 'PerformanceEntry');
5353
return this[kName];
5454
}
5555

5656
get entryType() {
57-
validateInternalField(this, kEntryType, 'PerformanceEntry');
57+
validateThisInternalField(this, kEntryType, 'PerformanceEntry');
5858
return this[kEntryType];
5959
}
6060

6161
get startTime() {
62-
validateInternalField(this, kStartTime, 'PerformanceEntry');
62+
validateThisInternalField(this, kStartTime, 'PerformanceEntry');
6363
return this[kStartTime];
6464
}
6565

6666
get duration() {
67-
validateInternalField(this, kDuration, 'PerformanceEntry');
67+
validateThisInternalField(this, kDuration, 'PerformanceEntry');
6868
return this[kDuration];
6969
}
7070

@@ -80,7 +80,7 @@ class PerformanceEntry {
8080
}
8181

8282
toJSON() {
83-
validateInternalField(this, kName, 'PerformanceEntry');
83+
validateThisInternalField(this, kName, 'PerformanceEntry');
8484
return {
8585
name: this[kName],
8686
entryType: this[kEntryType],
@@ -106,12 +106,12 @@ function createPerformanceEntry(name, type, start, duration) {
106106
*/
107107
class PerformanceNodeEntry extends PerformanceEntry {
108108
get detail() {
109-
validateInternalField(this, kDetail, 'NodePerformanceEntry');
109+
validateThisInternalField(this, kDetail, 'NodePerformanceEntry');
110110
return this[kDetail];
111111
}
112112

113113
toJSON() {
114-
validateInternalField(this, kName, 'PerformanceEntry');
114+
validateThisInternalField(this, kName, 'PerformanceEntry');
115115
return {
116116
name: this[kName],
117117
entryType: this[kEntryType],

lib/internal/perf/resource_timing.js

Lines changed: 24 additions & 24 deletions

0 commit comments

Comments
 (0)