tools: fix release URL computation in update-root-certs.mjs

joyeecheung · targos · commit 1efd74b1b092 · 2025-02-17T10:45:06.000+01:00
Previously this would compute the release tag to be something like FIREFOX_134_0.2_RELEASE which would not lead to a valid URL, failing to pull the latest NSS updates from the Firefox release. It should replace all the dots with underscores to compute something like FIREFOX_134_0_2_RELEASE instead. PR-URL: #56843 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
diff --git a/tools/dep_updaters/update-root-certs.mjs b/tools/dep_updaters/update-root-certs.mjs
@@ -65,7 +65,7 @@ const getFirefoxRelease = async (version) => {
 
 const getNSSVersion = async (release) => {
   const latestFirefox = release.version;
-  const firefoxTag = `FIREFOX_${latestFirefox.replace('.', '_')}_RELEASE`;
+  const firefoxTag = `FIREFOX_${latestFirefox.replaceAll('.', '_')}_RELEASE`;
   const tagInfoURL = `https://hg.mozilla.org/releases/mozilla-release/raw-file/${firefoxTag}/security/nss/TAG-INFO`;
   if (values.verbose) {
     console.log(`Fetching NSS tag from ${tagInfoURL}.`);
