win,tools: add description to signature

martincostello · aduh95 · commit 1eadab863c53 · 2025-10-11T22:57:14.000+02:00
When signing files for Windows, add "Node.js" as the description. PR-URL: #59877 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
diff --git a/tools/sign.bat b/tools/sign.bat
@@ -20,10 +20,10 @@ if "%AZURE_SIGN_METADATA_PATH%"=="" (
 )
 
 
-signtool sign /tr "http://timestamp.acs.microsoft.com" /td sha256 /fd sha256 /v /dlib %AZURE_SIGN_DLIB_PATH% /dmdf %AZURE_SIGN_METADATA_PATH% %1
+signtool sign /d "Node.js" /tr "http://timestamp.acs.microsoft.com" /td sha256 /fd sha256 /v /dlib %AZURE_SIGN_DLIB_PATH% /dmdf %AZURE_SIGN_METADATA_PATH% %1
 if not ERRORLEVEL 1 (
     echo Successfully signed %1 using signtool
     exit /b 0
 )
 echo Could not sign %1 using signtool
-exit /b 1
+exit /b 1

Original file line number	Diff line number	Diff line change
`@@ -20,10 +20,10 @@ if "%AZURE_SIGN_METADATA_PATH%"=="" (`
`20`	`20`	`)`
`21`	`21`
`22`	`22`
`23`		`-signtool sign /tr "http://timestamp.acs.microsoft.com" /td sha256 /fd sha256 /v /dlib %AZURE_SIGN_DLIB_PATH% /dmdf %AZURE_SIGN_METADATA_PATH% %1`
	`23`	`+signtool sign /d "Node.js" /tr "http://timestamp.acs.microsoft.com" /td sha256 /fd sha256 /v /dlib %AZURE_SIGN_DLIB_PATH% /dmdf %AZURE_SIGN_METADATA_PATH% %1`
`24`	`24`	`if not ERRORLEVEL 1 (`
`25`	`25`	`echo Successfully signed %1 using signtool`
`26`	`26`	`exit /b 0`
`27`	`27`	`)`
`28`	`28`	`echo Could not sign %1 using signtool`
`29`		`-exit /b 1`
	`29`	`+exit /b 1`