lib: add toJSON to PerformanceMeasure

theanarkh · marco-ippolito · commit 1e9ff5044631 · 2024-08-19T10:32:26.000+02:00
PR-URL: #53603 Refs: #53570 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
diff --git a/lib/internal/perf/usertiming.js b/lib/internal/perf/usertiming.js
@@ -136,6 +136,16 @@ class PerformanceMeasure extends PerformanceEntry {
     validateInternalField(this, kDetail, 'PerformanceMeasure');
     return this[kDetail];
   }
+
+  toJSON() {
+    return {
+      name: this.name,
+      entryType: this.entryType,
+      startTime: this.startTime,
+      duration: this.duration,
+      detail: this[kDetail],
+    };
+  }
 }
 ObjectDefineProperties(PerformanceMeasure.prototype, {
   detail: kEnumerableProperty,
diff --git a/test/parallel/test-performance-measure-detail.js b/test/parallel/test-performance-measure-detail.js
@@ -0,0 +1,20 @@
+'use strict';
+
+const common = require('../common');
+const assert = require('assert');
+const util = require('util');
+const { performance, PerformanceObserver } = require('perf_hooks');
+
+const perfObserver = new PerformanceObserver(common.mustCall((items) => {
+  const entries = items.getEntries();
+  assert.ok(entries.length === 1);
+  for (const entry of entries) {
+    assert.ok(util.inspect(entry).includes('this is detail'));
+  }
+}));
+
+perfObserver.observe({ entryTypes: ['measure'] });
+
+performance.measure('sample', {
+  detail: 'this is detail',
+});
