src: use FastStringKey for TrackV8FastApiCall

addaleax · aduh95 · commit 1e7639e9e1bc · 2025-08-04T13:35:54.000+02:00
This is the exact intended use case of `FastStringKey`. PR-URL: #59148 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Ilyas Shabi <ilyasshabi94@gmail.com>
diff --git a/src/node_debug.cc b/src/node_debug.cc
@@ -23,13 +23,14 @@ using v8::Number;
 using v8::Object;
 using v8::Value;
 
-thread_local std::unordered_map<std::string_view, int> v8_fast_api_call_counts;
+thread_local std::unordered_map<FastStringKey, int, FastStringKey::Hash>
+    v8_fast_api_call_counts;
 
-void TrackV8FastApiCall(std::string_view key) {
+void TrackV8FastApiCall(FastStringKey key) {
   v8_fast_api_call_counts[key]++;
 }
 
-int GetV8FastApiCallCount(std::string_view key) {
+int GetV8FastApiCallCount(FastStringKey key) {
   return v8_fast_api_call_counts[key];
 }
 
@@ -40,7 +41,8 @@ void GetV8FastApiCallCount(const FunctionCallbackInfo<Value>& args) {
     return;
   }
   Utf8Value utf8_key(env->isolate(), args[0]);
-  args.GetReturnValue().Set(GetV8FastApiCallCount(utf8_key.ToStringView()));
+  args.GetReturnValue().Set(GetV8FastApiCallCount(
+      FastStringKey::AllowDynamic(utf8_key.ToStringView())));
 }
 
 void SlowIsEven(const FunctionCallbackInfo<Value>& args) {
diff --git a/src/node_debug.h b/src/node_debug.h
@@ -3,17 +3,18 @@
 #if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS
 
 #ifdef DEBUG
-#include <string_view>
+#include "util.h"
 #endif  // DEBUG
 
 namespace node {
 namespace debug {
 
 #ifdef DEBUG
-void TrackV8FastApiCall(std::string_view key);
-int GetV8FastApiCallCount(std::string_view key);
+void TrackV8FastApiCall(FastStringKey key);
+int GetV8FastApiCallCount(FastStringKey key);
 
-#define TRACK_V8_FAST_API_CALL(key) node::debug::TrackV8FastApiCall(key)
+#define TRACK_V8_FAST_API_CALL(key)                                            \
+  node::debug::TrackV8FastApiCall(FastStringKey(key))
 #else  // !DEBUG
 #define TRACK_V8_FAST_API_CALL(key)
 #endif  // DEBUG

Original file line number	Diff line number	Diff line change
`@@ -23,13 +23,14 @@ using v8::Number;`
`23`	`23`	`using v8::Object;`
`24`	`24`	`using v8::Value;`
`25`	`25`
`26`		`-thread_local std::unordered_map<std::string_view, int> v8_fast_api_call_counts;`
	`26`	`+thread_local std::unordered_map<FastStringKey, int, FastStringKey::Hash>`
	`27`	`+ v8_fast_api_call_counts;`
`27`	`28`
`28`		`-void TrackV8FastApiCall(std::string_view key) {`
	`29`	`+void TrackV8FastApiCall(FastStringKey key) {`
`29`	`30`	`v8_fast_api_call_counts[key]++;`
`30`	`31`	`}`
`31`	`32`
`32`		`-int GetV8FastApiCallCount(std::string_view key) {`
	`33`	`+int GetV8FastApiCallCount(FastStringKey key) {`
`33`	`34`	`return v8_fast_api_call_counts[key];`
`34`	`35`	`}`
`35`	`36`
`@@ -40,7 +41,8 @@ void GetV8FastApiCallCount(const FunctionCallbackInfo<Value>& args) {`
`40`	`41`	`return;`
`41`	`42`	`}`
`42`	`43`	`Utf8Value utf8_key(env->isolate(), args[0]);`
`43`		`- args.GetReturnValue().Set(GetV8FastApiCallCount(utf8_key.ToStringView()));`
	`44`	`+ args.GetReturnValue().Set(GetV8FastApiCallCount(`
	`45`	`+ FastStringKey::AllowDynamic(utf8_key.ToStringView())));`
`44`	`46`	`}`
`45`	`47`
`46`	`48`	`void SlowIsEven(const FunctionCallbackInfo<Value>& args) {`