test: deflake test-http2-debug · nodejs/node@1be62ae · GitHub
Skip to content

Commit 1be62ae

Browse files
panvaaduh95
authored andcommitted
test: deflake test-http2-debug
Native debug writes can be lost when the non-blocking stderr pipe fills, leaving expected log lines missing even when the child exits successfully. Capture stderr in a temporary file and apply the existing assertions to its contents. Remove the flaky designation on Linux s390x. Fixes: #58353 Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: Codex PR-URL: #66151 Fixes: #52690 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent b9f61ea commit 1be62ae

2 files changed

Lines changed: 32 additions & 26 deletions

File tree

‎test/parallel/parallel.status‎

Lines changed: 0 additions & 4 deletions

‎test/parallel/test-http2-debug.js‎

Lines changed: 32 additions & 22 deletions

0 commit comments

Comments
 (0)