repl: handle errors from getters during completion

islandryu · aduh95 · commit 1a44265810b6 · 2025-07-21T10:59:01.000+02:00
PR-URL: #59044 Reviewed-By: Dario Piotrowicz <dario.piotrowicz@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/lib/repl.js b/lib/repl.js
@@ -1837,7 +1837,7 @@ function includesProxiesOrGetters(expr, exprStr, evalFn, ctx, callback) {
     if (astProp.type === 'Literal') {
       // We have something like `obj['foo'].x` where `x` is the literal
 
-      if (isProxy(obj[astProp.value])) {
+      if (safeIsProxyAccess(obj, astProp.value)) {
         return cb(true);
       }
 
@@ -1855,7 +1855,7 @@ function includesProxiesOrGetters(expr, exprStr, evalFn, ctx, callback) {
     ) {
       // We have something like `obj.foo.x` where `foo` is the identifier
 
-      if (isProxy(obj[astProp.name])) {
+      if (safeIsProxyAccess(obj, astProp.name)) {
         return cb(true);
       }
 
@@ -1882,7 +1882,7 @@ function includesProxiesOrGetters(expr, exprStr, evalFn, ctx, callback) {
         }
 
         if (typeof evaledProp === 'string') {
-          if (isProxy(obj[evaledProp])) {
+          if (safeIsProxyAccess(obj, evaledProp)) {
             return cb(true);
           }
 
@@ -1899,6 +1899,15 @@ function includesProxiesOrGetters(expr, exprStr, evalFn, ctx, callback) {
     );
   }
 
+  function safeIsProxyAccess(obj, prop) {
+    // Accessing `prop` may trigger a getter that throws, so we use try-catch to guard against it
+    try {
+      return isProxy(obj[prop]);
+    } catch {
+      return false;
+    }
+  }
+
   return callback(false);
 }
 
diff --git a/test/parallel/test-repl-tab-complete-getter-error.js b/test/parallel/test-repl-tab-complete-getter-error.js
@@ -0,0 +1,51 @@
+'use strict';
+
+const common = require('../common');
+const repl = require('repl');
+const ArrayStream = require('../common/arraystream');
+const assert = require('assert');
+
+(async function() {
+  await runTest();
+})().then(common.mustCall());
+
+async function runTest() {
+  const input = new ArrayStream();
+  const output = new ArrayStream();
+
+  const replServer = repl.start({
+    prompt: '',
+    input,
+    output: output,
+    allowBlockingCompletions: true,
+    terminal: true
+  });
+
+  replServer._domain.on('error', (e) => {
+    assert.fail(`Error in REPL domain: ${e}`);
+  });
+
+  await new Promise((resolve, reject) => {
+    replServer.eval(`
+     const getNameText = () => "name";
+     const foo = { get name() { throw new Error(); } };
+     `, replServer.context, '', (err) => {
+      if (err) {
+        reject(err);
+      } else {
+        resolve();
+      }
+    });
+  });
+
+  ['foo.name.', 'foo["name"].', 'foo[getNameText()].'].forEach((test) => {
+    replServer.complete(
+      test,
+      common.mustCall((error, data) => {
+        assert.strictEqual(error, null);
+        assert.strictEqual(data.length, 2);
+        assert.strictEqual(data[1], test);
+      })
+    );
+  });
+}

Original file line number	Diff line number	Diff line change
`@@ -1837,7 +1837,7 @@ function includesProxiesOrGetters(expr, exprStr, evalFn, ctx, callback) {`
`1837`	`1837`	`if (astProp.type === 'Literal') {`
`1838`	`1838`	// We have something like `obj['foo'].x` where `x` is the literal
`1839`	`1839`
`1840`		`- if (isProxy(obj[astProp.value])) {`
	`1840`	`+ if (safeIsProxyAccess(obj, astProp.value)) {`
`1841`	`1841`	`return cb(true);`
`1842`	`1842`	`}`
`1843`	`1843`
`@@ -1855,7 +1855,7 @@ function includesProxiesOrGetters(expr, exprStr, evalFn, ctx, callback) {`
`1855`	`1855`	`) {`
`1856`	`1856`	// We have something like `obj.foo.x` where `foo` is the identifier
`1857`	`1857`
`1858`		`- if (isProxy(obj[astProp.name])) {`
	`1858`	`+ if (safeIsProxyAccess(obj, astProp.name)) {`
`1859`	`1859`	`return cb(true);`
`1860`	`1860`	`}`
`1861`	`1861`
`@@ -1882,7 +1882,7 @@ function includesProxiesOrGetters(expr, exprStr, evalFn, ctx, callback) {`
`1882`	`1882`	`}`
`1883`	`1883`
`1884`	`1884`	`if (typeof evaledProp === 'string') {`
`1885`		`- if (isProxy(obj[evaledProp])) {`
	`1885`	`+ if (safeIsProxyAccess(obj, evaledProp)) {`
`1886`	`1886`	`return cb(true);`
`1887`	`1887`	`}`
`1888`	`1888`
`@@ -1899,6 +1899,15 @@ function includesProxiesOrGetters(expr, exprStr, evalFn, ctx, callback) {`
`1899`	`1899`	`);`
`1900`	`1900`	`}`
`1901`	`1901`
	`1902`	`+ function safeIsProxyAccess(obj, prop) {`
	`1903`	+ // Accessing `prop` may trigger a getter that throws, so we use try-catch to guard against it
	`1904`	`+ try {`
	`1905`	`+ return isProxy(obj[prop]);`
	`1906`	`+ } catch {`
	`1907`	`+ return false;`
	`1908`	`+ }`
	`1909`	`+ }`
	`1910`	`+`
`1902`	`1911`	`return callback(false);`
`1903`	`1912`	`}`
`1904`	`1913`