stream: fix broken pipeline test

ronag · BethGriggs · commit 1a2b3eb3a474 · 2020-04-28T16:28:28.000+01:00
An unfortunate overlap between two PR that by themselves pass CI but together pass a test. #32967 changes so that pipeline does not wait for 'close'. #32968 changed so that all streams are not destroyed. Which made one test fail when expected the stream to be destroyed during pipeline callback. PR-URL: #33030 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
diff --git a/test/parallel/test-stream-pipeline.js b/test/parallel/test-stream-pipeline.js
@@ -982,7 +982,7 @@ const net = require('net');
   dst.readable = false;
   pipeline(src, dst, common.mustCall((err) => {
     assert(!err);
-    assert.strictEqual(dst.destroyed, true);
+    assert.strictEqual(dst.destroyed, false);
   }));
   src.end();
 }

Original file line number	Diff line number	Diff line change
`@@ -982,7 +982,7 @@ const net = require('net');`
`982`	`982`	`dst.readable = false;`
`983`	`983`	`pipeline(src, dst, common.mustCall((err) => {`
`984`	`984`	`assert(!err);`
`985`		`- assert.strictEqual(dst.destroyed, true);`
	`985`	`+ assert.strictEqual(dst.destroyed, false);`
`986`	`986`	`}));`
`987`	`987`	`src.end();`
`988`	`988`	`}`