src: fix signal handler crash on close

codebytere · addaleax · commit 1916acb3cbe3 · 2019-11-30T03:48:16.000+01:00
PR-URL: #30582 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>
diff --git a/src/signal_wrap.cc b/src/signal_wrap.cc
@@ -91,7 +91,10 @@ class SignalWrap : public HandleWrap {
   }
 
   void Close(v8::Local<v8::Value> close_callback) override {
-    if (active_) DecreaseSignalHandlerCount(handle_.signum);
+    if (active_) {
+      DecreaseSignalHandlerCount(handle_.signum);
+      active_ = false;
+    }
     HandleWrap::Close(close_callback);
   }
 

Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,10 @@ class SignalWrap : public HandleWrap {`
`91`	`91`	`}`
`92`	`92`
`93`	`93`	`void Close(v8::Local<v8::Value> close_callback) override {`
`94`		`- if (active_) DecreaseSignalHandlerCount(handle_.signum);`
	`94`	`+ if (active_) {`
	`95`	`+ DecreaseSignalHandlerCount(handle_.signum);`
	`96`	`+ active_ = false;`
	`97`	`+ }`
`95`	`98`	`HandleWrap::Close(close_callback);`
`96`	`99`	`}`
`97`	`100`