test_runner: set non-zero exit code when suite errors occur

geeksilva97 · aduh95 · commit 1865691275ce · 2026-03-30T17:20:26.000+02:00
PR-URL: #62282 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
diff --git a/lib/internal/test_runner/utils.js b/lib/internal/test_runner/utils.js
@@ -384,6 +384,9 @@ function countCompletedTest(test, harness = test.root.harness) {
   }
   if (test.reportedType === 'suite') {
     harness.counters.suites++;
+    if (!test.passed) {
+      harness.success = false;
+    }
     return;
   }
   // Check SKIP and TODO tests first, as those should not be counted as
diff --git a/test/fixtures/test-runner/describe_error.js b/test/fixtures/test-runner/describe_error.js
@@ -0,0 +1,10 @@
+'use strict';
+const { describe, it } = require('node:test');
+
+describe('should fail', () => {
+  throw new Error('error in describe');
+});
+
+describe('should pass', () => {
+  it('ok', () => {});
+});
diff --git a/test/parallel/test-runner-exit-code.js b/test/parallel/test-runner-exit-code.js
@@ -70,6 +70,14 @@ if (process.argv[2] === 'child') {
   assert.strictEqual(child.status, 1);
   assert.strictEqual(child.signal, null);
 
+  // An error thrown inside describe() should cause a non-zero exit code.
+  child = spawnSync(process.execPath, [
+    '--test',
+    fixtures.path('test-runner', 'describe_error.js'),
+  ]);
+  assert.strictEqual(child.status, 1);
+  assert.strictEqual(child.signal, null);
+
   // With process isolation (default), the test name shown is the file path
   // because the parent runner only knows about file-level tests
   const neverEndingSync = fixtures.path('test-runner', 'never_ending_sync.js');

Original file line number	Diff line number	Diff line change
`@@ -384,6 +384,9 @@ function countCompletedTest(test, harness = test.root.harness) {`
`384`	`384`	`}`
`385`	`385`	`if (test.reportedType === 'suite') {`
`386`	`386`	`harness.counters.suites++;`
	`387`	`+ if (!test.passed) {`
	`388`	`+ harness.success = false;`
	`389`	`+ }`
`387`	`390`	`return;`
`388`	`391`	`}`
`389`	`392`	`// Check SKIP and TODO tests first, as those should not be counted as`