test: duplicated buffer in test-stream2-writable.js

duvanmonsa · targos · commit 16926a818385 · 2019-07-02T09:07:55.000+02:00
PR-URL: #28380 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Adrian Estrada <edsadr@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
diff --git a/test/parallel/test-stream2-writable.js b/test/parallel/test-stream2-writable.js
@@ -229,10 +229,12 @@ for (let i = 0; i < chunks.length; i++) {
   tw.end(common.mustCall());
 }
 
+const helloWorldBuffer = Buffer.from('hello world');
+
 {
   // Verify end() callback with chunk
   const tw = new TestWriter();
-  tw.end(Buffer.from('hello world'), common.mustCall());
+  tw.end(helloWorldBuffer, common.mustCall());
 }
 
 {
@@ -244,15 +246,15 @@ for (let i = 0; i < chunks.length; i++) {
 {
   // Verify end() callback after write() call
   const tw = new TestWriter();
-  tw.write(Buffer.from('hello world'));
+  tw.write(helloWorldBuffer);
   tw.end(common.mustCall());
 }
 
 {
   // Verify end() callback after write() callback
   const tw = new TestWriter();
   let writeCalledback = false;
-  tw.write(Buffer.from('hello world'), function() {
+  tw.write(helloWorldBuffer, function() {
     writeCalledback = true;
   });
   tw.end(common.mustCall(function() {

Original file line number	Diff line number	Diff line change
`@@ -229,10 +229,12 @@ for (let i = 0; i < chunks.length; i++) {`
`229`	`229`	`tw.end(common.mustCall());`
`230`	`230`	`}`
`231`	`231`
	`232`	`+const helloWorldBuffer = Buffer.from('hello world');`
	`233`	`+`
`232`	`234`	`{`
`233`	`235`	`// Verify end() callback with chunk`
`234`	`236`	`const tw = new TestWriter();`
`235`		`- tw.end(Buffer.from('hello world'), common.mustCall());`
	`237`	`+ tw.end(helloWorldBuffer, common.mustCall());`
`236`	`238`	`}`
`237`	`239`
`238`	`240`	`{`
`@@ -244,15 +246,15 @@ for (let i = 0; i < chunks.length; i++) {`
`244`	`246`	`{`
`245`	`247`	`// Verify end() callback after write() call`
`246`	`248`	`const tw = new TestWriter();`
`247`		`- tw.write(Buffer.from('hello world'));`
	`249`	`+ tw.write(helloWorldBuffer);`
`248`	`250`	`tw.end(common.mustCall());`
`249`	`251`	`}`
`250`	`252`
`251`	`253`	`{`
`252`	`254`	`// Verify end() callback after write() callback`
`253`	`255`	`const tw = new TestWriter();`
`254`	`256`	`let writeCalledback = false;`
`255`		`- tw.write(Buffer.from('hello world'), function() {`
	`257`	`+ tw.write(helloWorldBuffer, function() {`
`256`	`258`	`writeCalledback = true;`
`257`	`259`	`});`
`258`	`260`	`tw.end(common.mustCall(function() {`