dns: validate address type in lookupService · nodejs/node@152a326 · GitHub
Skip to content

Commit 152a326

Browse files
lazergaduh95
authored andcommitted
dns: validate address type in lookupService
Signed-off-by: Lazizbek Ergashev <lazerg2@gmail.com> PR-URL: #64878 Fixes: #64877 Reviewed-By: theanarkh <theratliter@gmail.com> Reviewed-By: Tim Perry <pimterry@gmail.com>
1 parent 88d5f64 commit 152a326

3 files changed

Lines changed: 23 additions & 0 deletions

File tree

lib/dns.js

Lines changed: 3 additions & 0 deletions

lib/internal/dns/promises.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -282,6 +282,8 @@ function lookupService(address, port) {
282282
if (arguments.length !== 2)
283283
throw new ERR_MISSING_ARGS('address', 'port');
284284

285+
validateString(address, 'address');
286+
285287
if (isIP(address) === 0)
286288
throw new ERR_INVALID_ARG_VALUE('address', address);
287289

test/parallel/test-dns.js

Lines changed: 18 additions & 0 deletions

0 commit comments

Comments
 (0)