lib: runtime deprecate access to process.binding('async_wrap')

jasnell · jasnell · commit 1468c9ff7c25 · 2021-03-08T07:57:39.000-08:00
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #37576 Fixes: #37575 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
diff --git a/lib/internal/bootstrap/loaders.js b/lib/internal/bootstrap/loaders.js
@@ -105,6 +105,10 @@ const internalBindingAllowlist = new SafeSet([
   'zlib',
 ]);
 
+const runtimeDeprecatedList = new SafeSet([
+  'async_wrap',
+]);
+
 // Set up process.binding() and process._linkedBinding().
 {
   const bindingObj = ObjectCreate(null);
@@ -114,6 +118,13 @@ const internalBindingAllowlist = new SafeSet([
     // Deprecated specific process.binding() modules, but not all, allow
     // selective fallback to internalBinding for the deprecated ones.
     if (internalBindingAllowlist.has(module)) {
+      if (runtimeDeprecatedList.has(module)) {
+        runtimeDeprecatedList.delete(module);
+        process.emitWarning(
+          `Access to process.binding('${module}') is deprecated.`,
+          'DeprecationWarning',
+          'DEP0111');
+      }
       return internalBinding(module);
     }
     // eslint-disable-next-line no-restricted-syntax
