test: fail for missing output files

addaleax · MylesBorins · commit 13c6cec4334f · 2017-01-31T20:04:29.000-05:00
Instead of ignoring missing `.out` files for message/pseudo-tty tests, raise an error to indicate that something is not quite right. Ref: #10037 PR-URL: #10150 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
diff --git a/test/message/testcfg.py b/test/message/testcfg.py
@@ -127,8 +127,7 @@ def ListTests(self, current_path, path, arch, mode):
         file_path = file_prefix + ".js"
         output_path = file_prefix + ".out"
         if not exists(output_path):
-          print "Could not find %s" % output_path
-          continue
+          raise Exception("Could not find %s" % output_path)
         result.append(MessageTestCase(test, file_path, output_path,
                                       arch, mode, self.context, self))
     return result
diff --git a/test/pseudo-tty/testcfg.py b/test/pseudo-tty/testcfg.py
@@ -142,8 +142,7 @@ def ListTests(self, current_path, path, arch, mode):
         file_path = file_prefix + ".js"
         output_path = file_prefix + ".out"
         if not exists(output_path):
-          print "Could not find %s" % output_path
-          continue
+          raise Exception("Could not find %s" % output_path)
         result.append(TTYTestCase(test, file_path, output_path,
                                       arch, mode, self.context, self))
     return result
