crypto: avoid copying buffers to UTF-8 strings in crypto.hash()

Renegade334 · aduh95 · commit 135fca5b7269 · 2025-07-21T10:59:01.000+02:00
PR-URL: #59067 Fixes: #59057 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
diff --git a/src/crypto/crypto_hash.cc b/src/crypto/crypto_hash.cc
@@ -274,26 +274,23 @@ void Hash::OneShotDigest(const FunctionCallbackInfo<Value>& args) {
   }
 
   DataPointer output = ([&]() -> DataPointer {
-    Utf8Value utf8(isolate, args[3]);
-    ncrypto::Buffer<const unsigned char> buf;
     if (args[3]->IsString()) {
-      buf = {
+      Utf8Value utf8(isolate, args[3]);
+      ncrypto::Buffer<const unsigned char> buf = {
           .data = reinterpret_cast<const unsigned char*>(utf8.out()),
           .len = utf8.length(),
       };
-    } else {
-      ArrayBufferViewContents<unsigned char> input(args[3]);
-      buf = {
-          .data = reinterpret_cast<const unsigned char*>(input.data()),
-          .len = input.length(),
-      };
-    }
-
-    if (is_xof) {
-      return ncrypto::xofHashDigest(buf, md, output_length);
+      return is_xof ? ncrypto::xofHashDigest(buf, md, output_length)
+                    : ncrypto::hashDigest(buf, md);
     }
 
-    return ncrypto::hashDigest(buf, md);
+    ArrayBufferViewContents<unsigned char> input(args[3]);
+    ncrypto::Buffer<const unsigned char> buf = {
+        .data = reinterpret_cast<const unsigned char*>(input.data()),
+        .len = input.length(),
+    };
+    return is_xof ? ncrypto::xofHashDigest(buf, md, output_length)
+                  : ncrypto::hashDigest(buf, md);
   })();
 
   if (!output) [[unlikely]] {
