Revert "test: add tests for REPL custom evals"

tniessen · RafaelGSS · commit 12f4124af894 · 2025-05-02T17:06:11.000-03:00
This reverts commit 1f7cfb7, which was merged into the main branch despite relevant test failures. PR-URL: #57793 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
diff --git a/lib/repl.js b/lib/repl.js
@@ -302,6 +302,7 @@ function REPLServer(prompt,
     options.useColors = shouldColorize(options.output);
   }
 
+  // TODO(devsnek): Add a test case for custom eval functions.
   const preview = options.terminal &&
     (options.preview !== undefined ? !!options.preview : !eval_);
 
diff --git a/test/parallel/test-repl-custom-eval.js b/test/parallel/test-repl-custom-eval.js
diff --git a/test/parallel/test-repl-eval.js b/test/parallel/test-repl-eval.js
@@ -0,0 +1,33 @@
+'use strict';
+const common = require('../common');
+const assert = require('assert');
+const repl = require('repl');
+
+{
+  let evalCalledWithExpectedArgs = false;
+
+  const options = {
+    eval: common.mustCall((cmd, context) => {
+      // Assertions here will not cause the test to exit with an error code
+      // so set a boolean that is checked later instead.
+      evalCalledWithExpectedArgs = (cmd === 'function f() {}\n' &&
+                                    context.foo === 'bar');
+    })
+  };
+
+  const r = repl.start(options);
+  r.context = { foo: 'bar' };
+
+  try {
+    // Default preprocessor transforms
+    //  function f() {}  to
+    //  var f = function f() {}
+    // Test to ensure that original input is preserved.
+    // Reference: https://github.com/nodejs/node/issues/9743
+    r.write('function f() {}\n');
+  } finally {
+    r.write('.exit\n');
+  }
+
+  assert(evalCalledWithExpectedArgs);
+}

Original file line number	Diff line number	Diff line change
`@@ -302,6 +302,7 @@ function REPLServer(prompt,`
`302`	`302`	`options.useColors = shouldColorize(options.output);`
`303`	`303`	`}`
`304`	`304`
	`305`	`+ // TODO(devsnek): Add a test case for custom eval functions.`
`305`	`306`	`const preview = options.terminal &&`
`306`	`307`	`(options.preview !== undefined ? !!options.preview : !eval_);`
`307`	`308`