test: change var declarations, add mustCall check

Daniel Sims · MylesBorins · commit 122917df5a1d · 2017-01-31T20:04:28.000-05:00
In this test, I changed the var declarations to be either a let or a const. For some of the callbacks, I added a mustCall check to ensure that the functions have run. I also changed assert.equal() to assert.strictEqual(). PR-URL: #9962 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
diff --git a/test/parallel/test-cluster-net-send.js b/test/parallel/test-cluster-net-send.js
@@ -1,50 +1,51 @@
 'use strict';
-var common = require('../common');
-var assert = require('assert');
-var fork = require('child_process').fork;
-var net = require('net');
+const common = require('../common');
+const assert = require('assert');
+const fork = require('child_process').fork;
+const net = require('net');
 
 if (process.argv[2] !== 'child') {
   console.error('[%d] master', process.pid);
 
-  var worker = fork(__filename, ['child']);
-  var called = false;
+  const worker = fork(__filename, ['child']);
+  let called = false;
 
-  worker.once('message', function(msg, handle) {
-    assert.equal(msg, 'handle');
+  worker.once('message', common.mustCall(function(msg, handle) {
+    assert.strictEqual(msg, 'handle');
     assert.ok(handle);
     worker.send('got');
 
     handle.on('data', function(data) {
       called = true;
-      assert.equal(data.toString(), 'hello');
+      assert.strictEqual(data.toString(), 'hello');
     });
 
     handle.on('end', function() {
       worker.kill();
     });
-  });
+  }));
 
   process.once('exit', function() {
     assert.ok(called);
   });
 } else {
   console.error('[%d] worker', process.pid);
 
-  var socket;
-  var cbcalls = 0;
+  let socket;
+  let cbcalls = 0;
   function socketConnected() {
     if (++cbcalls === 2)
       process.send('handle', socket);
   }
 
-  var server = net.createServer(function(c) {
-    process.once('message', function(msg) {
-      assert.equal(msg, 'got');
+  const server = net.createServer(function(c) {
+    process.once('message', common.mustCall(function(msg) {
+      assert.strictEqual(msg, 'got');
       c.end('hello');
-    });
+    }));
     socketConnected();
   });
+
   server.listen(common.PORT, function() {
     socket = net.connect(common.PORT, '127.0.0.1', socketConnected);
   });
