test: widen the gap in the resolver maxTimeout comparison · nodejs/node@1222ab3 · GitHub
Skip to content

Commit 1222ab3

Browse files
codebytereaduh95
authored andcommitted
test: widen the gap in the resolver maxTimeout comparison
test-dns-resolver-max-timeout times a query with `{ timeout: 500, tries: 3 }` against one that also sets `maxTimeout: 500` and asserts the first took longer. c-ares only expires a try when cares_wrap's timer fires, every `timeout` ms, so each try costs one or two ticks depending on sub-millisecond ordering, and uncapped retries also get 0.5-1x jitter. That leaves the capped run anywhere in 1500-3000 ms and the uncapped one in 3000-4500 ms; on a busy rhel10-ppc64le host both came out at 3005 ms. With `timeout: 100, tries: 5` the ranges (about 600-1000 ms and 5000-7500 ms measured under load) cannot meet. Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com> PR-URL: #65780 Fixes: #64226 Refs: #59146 Refs: #54534 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
1 parent 379f9c3 commit 1222ab3

1 file changed

Lines changed: 5 additions & 3 deletions

File tree

‎test/parallel/test-dns-resolver-max-timeout.js‎

Lines changed: 5 additions & 3 deletions

0 commit comments

Comments
 (0)