benchmark: add implicit-framing case to http/set-header · nodejs/node@11c3d71 · GitHub
Skip to content

Commit 11c3d71

Browse files
mcollinaaduh95
authored andcommitted
benchmark: add implicit-framing case to http/set-header
The existing `setHeader` and `setHeaderWH` cases set `Content-Length` explicitly, and `normal` passes every header to `writeHead()`. The very common handler shape `res.setHeader(...)` + `res.end(body)`, where `end()` derives the framing, exercises a different path and was not covered. Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #66420 Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
1 parent 83a1697 commit 11c3d71

2 files changed

Lines changed: 8 additions & 1 deletion

File tree

‎benchmark/fixtures/simple-http-server.js‎

Lines changed: 6 additions & 0 deletions

‎benchmark/http/set-header.js‎

Lines changed: 2 additions & 1 deletion

0 commit comments

Comments
 (0)