errors: remove needless lazyAssert

davidtaikocha · MylesBorins · commit 0f2642ee3603 · 2017-03-28T18:28:55.000-04:00
PR-URL: #11891 Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
diff --git a/lib/internal/errors.js b/lib/internal/errors.js
@@ -6,16 +6,11 @@
 // value statically and permanently identifies the error. While the error
 // message may change, the code should not.
 
+const assert = require('assert');
 const kCode = Symbol('code');
 const messages = new Map();
 
-var assert, util;
-function lazyAssert() {
-  if (!assert)
-    assert = require('assert');
-  return assert;
-}
-
+var util;
 function lazyUtil() {
   if (!util)
     util = require('util');
@@ -41,7 +36,6 @@ function makeNodeError(Base) {
 }
 
 function message(key, args) {
-  const assert = lazyAssert();
   assert.strictEqual(typeof key, 'string');
   const util = lazyUtil();
   const msg = messages.get(key);
@@ -60,7 +54,6 @@ function message(key, args) {
 // Utility function for registering the error codes. Only used here. Exported
 // *only* to allow for testing.
 function E(sym, val) {
-  const assert = lazyAssert();
   assert(messages.has(sym) === false, `Error symbol: ${sym} was already used.`);
   messages.set(sym, typeof val === 'function' ? val : String(val));
 }
