tools: label PRs lacking second approval · nodejs/node@0cdd317 · GitHub
Skip to content

Commit 0cdd317

Browse files
panvaaduh95
authored andcommitted
tools: label PRs lacking second approval
Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #65538 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im>
1 parent 8bc17b0 commit 0cdd317

3 files changed

Lines changed: 69 additions & 5 deletions

File tree

‎.github/workflows/commit-queue.yml‎

Lines changed: 27 additions & 0 deletions

‎doc/contributing/commit-queue.md‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,11 @@ landing process by automating it via GitHub Actions. With it, collaborators can
88
queue pull requests for landing by adding the `commit-queue` label to a PR. The
99
selector checks readiness with `@node-core/utils`. If the pull request is only
1010
blocked on a deferrable condition, currently wait time, the queue leaves the
11-
label in place and retries later. Other failures continue to the existing
12-
landing and failure-reporting path.
11+
label in place and retries later. For pull requests that are at least two days
12+
old and still waiting for a second approval, the queue adds the
13+
`lacks-second-approval` label. The queue removes that label when it removes the
14+
`commit-queue` label. Other failures continue to the existing landing and
15+
failure-reporting path.
1316

1417
To make the Commit Queue squash all the commits of a pull request into the
1518
first one, add the `commit-queue-squash` label.

‎tools/actions/commit-queue.sh‎

Lines changed: 37 additions & 3 deletions

0 commit comments

Comments
 (0)