lib: fix a few minor issues flagged by lgtm

rneatherway · addaleax · commit 0b302e452096 · 2019-02-06T22:30:49.000+01:00
* Confusing (but correct) regex using `A-z` character range by accident * Add the status argument to afterShutdown PR-URL: #25873 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
diff --git a/lib/internal/http2/core.js b/lib/internal/http2/core.js
@@ -1518,7 +1518,8 @@ function streamOnPause() {
     this[kHandle].readStop();
 }
 
-function afterShutdown() {
+function afterShutdown(status) {
+  // Currently this status value is unused
   this.callback();
   const stream = this.handle[kOwner];
   if (stream)
diff --git a/tools/cpplint.py b/tools/cpplint.py
@@ -636,7 +636,7 @@ def GetNonHeaderExtensions():
 
 _RIGHT_LEANING_POINTER_PATTERN = re.compile(r'[^=|(,\s><);&?:}]'
                                             r'(?<!(sizeof|return))'
-                                            r'\s\*[a-zA-z_][0-9a-zA-z_]*')
+                                            r'\s\*[a-zA-Z_][0-9a-zA-Z_]*')
 
 _regexp_compile_cache = {}
 

Original file line number	Diff line number	Diff line change
`@@ -1518,7 +1518,8 @@ function streamOnPause() {`
`1518`	`1518`	`this[kHandle].readStop();`
`1519`	`1519`	`}`
`1520`	`1520`
`1521`		`-function afterShutdown() {`
	`1521`	`+function afterShutdown(status) {`
	`1522`	`+ // Currently this status value is unused`
`1522`	`1523`	`this.callback();`
`1523`	`1524`	`const stream = this.handle[kOwner];`
`1524`	`1525`	`if (stream)`