test: correct header length subtraction

Trott · MylesBorins · commit 0b0cd8d06233 · 2019-12-17T17:07:02.000-05:00
In test-http-max-http-headers, a comment asks why we are subtracting 32 from the length of the invalid-length-by-1 headers instead of just 1. Subtracting 1 seems to be correct and works. PR-URL: #30712 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/test/sequential/test-http-max-http-headers.js b/test/sequential/test-http-max-http-headers.js
@@ -42,8 +42,7 @@ function fillHeaders(headers, currentSize, valid = false) {
 
   // Generate valid headers
   if (valid) {
-    // TODO(mcollina): understand why -32 is needed instead of -1
-    headers = headers.slice(0, -32);
+    headers = headers.slice(0, -1);
   }
   return headers + '\r\n\r\n';
 }

Original file line number	Diff line number	Diff line change
`@@ -42,8 +42,7 @@ function fillHeaders(headers, currentSize, valid = false) {`
`42`	`42`
`43`	`43`	`// Generate valid headers`
`44`	`44`	`if (valid) {`
`45`		`- // TODO(mcollina): understand why -32 is needed instead of -1`
`46`		`- headers = headers.slice(0, -32);`
	`45`	`+ headers = headers.slice(0, -1);`
`47`	`46`	`}`
`48`	`47`	`return headers + '\r\n\r\n';`
`49`	`48`	`}`