test: apply a delay to watch-mode-kill-signal tests

joyeecheung · aduh95 · commit 09726269de46 · 2025-11-13T22:44:24.000+01:00
The test is still flaking on macOS. This might be caused by fs event coalescing. Apply a delay to reduce the chance of it. Also, add a bit more logs to show more information. PR-URL: #60610 Refs: https://github.com/nodejs/reliability/blob/main/reports/2025-11-07.md Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
diff --git a/test/fixtures/kill-signal-for-watch.js b/test/fixtures/kill-signal-for-watch.js
@@ -7,4 +7,7 @@ process.on('SIGINT', () => {
   process.exit();
 });
 process.send(`script ready ${process.pid}`);
-setTimeout(() => {}, 100_000);
+const timeout = 100_000;
+setTimeout(() => {
+  process._rawDebug(`[CHILD] Timeout ${timeout} fired`);
+}, timeout);
diff --git a/test/parallel/test-watch-mode-kill-signal-default.mjs b/test/parallel/test-watch-mode-kill-signal-default.mjs
@@ -51,7 +51,12 @@ child.on('message', (msg) => {
     const match = msg.match(/script ready (\d+)/);
     if (match) {
       firstGrandchildPid = match[1];  // This is the first grandchild
-      writeFileSync(indexPath, indexContents);
+      const writeDelay = 1000;  // Delay to reduce the chance of fs events coalescing
+      console.log(`[PARENT] writing to restart ${firstGrandchildPid} after ${writeDelay}ms`);
+      setTimeout(() => {
+        console.log(`[PARENT] writing to ${indexPath} to restart ${firstGrandchildPid}`);
+        writeFileSync(indexPath, indexContents);
+      }, writeDelay);
     }
   }
 });
diff --git a/test/parallel/test-watch-mode-kill-signal-override.mjs b/test/parallel/test-watch-mode-kill-signal-override.mjs
@@ -52,7 +52,12 @@ child.on('message', (msg) => {
     const match = msg.match(/script ready (\d+)/);
     if (match) {
       firstGrandchildPid = match[1];  // This is the first grandchild
-      writeFileSync(indexPath, indexContents);
+      const writeDelay = 1000;  // Delay to reduce the chance of fs events coalescing
+      console.log(`[PARENT] writing to restart ${firstGrandchildPid} after ${writeDelay}ms`);
+      setTimeout(() => {
+        console.log(`[PARENT] writing to ${indexPath} to restart ${firstGrandchildPid}`);
+        writeFileSync(indexPath, indexContents);
+      }, writeDelay);
     }
   }
 });

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,12 @@ child.on('message', (msg) => {`
`51`	`51`	`const match = msg.match(/script ready (\d+)/);`
`52`	`52`	`if (match) {`
`53`	`53`	`firstGrandchildPid = match[1]; // This is the first grandchild`
`54`		`- writeFileSync(indexPath, indexContents);`
	`54`	`+ const writeDelay = 1000; // Delay to reduce the chance of fs events coalescing`
	`55`	+ console.log(`[PARENT] writing to restart ${firstGrandchildPid} after ${writeDelay}ms`);
	`56`	`+ setTimeout(() => {`
	`57`	+ console.log(`[PARENT] writing to ${indexPath} to restart ${firstGrandchildPid}`);
	`58`	`+ writeFileSync(indexPath, indexContents);`
	`59`	`+ }, writeDelay);`
`55`	`60`	`}`
`56`	`61`	`}`
`57`	`62`	`});`
Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,12 @@ child.on('message', (msg) => {`
`52`	`52`	`const match = msg.match(/script ready (\d+)/);`
`53`	`53`	`if (match) {`
`54`	`54`	`firstGrandchildPid = match[1]; // This is the first grandchild`
`55`		`- writeFileSync(indexPath, indexContents);`
	`55`	`+ const writeDelay = 1000; // Delay to reduce the chance of fs events coalescing`
	`56`	+ console.log(`[PARENT] writing to restart ${firstGrandchildPid} after ${writeDelay}ms`);
	`57`	`+ setTimeout(() => {`
	`58`	+ console.log(`[PARENT] writing to ${indexPath} to restart ${firstGrandchildPid}`);
	`59`	`+ writeFileSync(indexPath, indexContents);`
	`60`	`+ }, writeDelay);`
`56`	`61`	`}`
`57`	`62`	`}`
`58`	`63`	`});`