fs: fix fs.promises.realpath for long paths on Windows

sapphi-red · RafaelGSS · commit 091098f40a25 · 2024-01-02T15:05:27.000-03:00
Unlike other fs functions that work with paths, realpath isn't using pathModule.toNamespacedPath prior to calling libuv function. This is causing issues on windows. Windows long path test is also improved to cover the mentioned issue. Fixes: #51031 PR-URL: #51032 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/lib/internal/fs/promises.js b/lib/internal/fs/promises.js
@@ -1160,7 +1160,7 @@ async function realpath(path, options) {
   options = getOptions(options);
   path = getValidatedPath(path);
   return await PromisePrototypeThen(
-    binding.realpath(path, options.encoding, kUsePromises),
+    binding.realpath(pathModule.toNamespacedPath(path), options.encoding, kUsePromises),
     undefined,
     handleErrorFromBinding,
   );
diff --git a/test/parallel/test-fs-long-path.js b/test/parallel/test-fs-long-path.js
@@ -46,4 +46,7 @@ fs.writeFile(fullPath, 'ok', common.mustSucceed(() => {
 
   // Tests https://github.com/nodejs/node/issues/39721
   fs.realpath.native(fullPath, common.mustSucceed());
+
+  // Tests https://github.com/nodejs/node/issues/51031
+  fs.promises.realpath(fullPath).then(common.mustCall(), common.mustNotCall());
 }));
