policy: revise manifest.js to avoid empty blocks

Trott · danielleadams · commit 08b3bd2fc58f · 2022-03-14T09:32:21.000-04:00
PR-URL: #41831 Backport-PR-URL: #42160 Refs: https://eslint.org/docs/rules/no-empty Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
diff --git a/lib/internal/policy/manifest.js b/lib/internal/policy/manifest.js
@@ -430,12 +430,11 @@ class Manifest {
 
     if (objectButNotArray(obj) && 'onerror' in obj) {
       const behavior = obj.onerror;
-      if (behavior === 'throw') {
-      } else if (behavior === 'exit') {
+      if (behavior === 'exit') {
         reaction = REACTION_EXIT;
       } else if (behavior === 'log') {
         reaction = REACTION_LOG;
-      } else {
+      } else if (behavior !== 'throw') {
         throw new ERR_MANIFEST_UNKNOWN_ONERROR(behavior);
       }
     }
@@ -579,8 +578,7 @@ class Manifest {
         const entry = this.#scopeIntegrities.get(scope);
         if (entry === true) {
           return true;
-        } else if (entry === kCascade) {
-        } else {
+        } else if (entry !== kCascade) {
           break;
         }
       }

Original file line number	Diff line number	Diff line change
`@@ -430,12 +430,11 @@ class Manifest {`
`430`	`430`
`431`	`431`	`if (objectButNotArray(obj) && 'onerror' in obj) {`
`432`	`432`	`const behavior = obj.onerror;`
`433`		`- if (behavior === 'throw') {`
`434`		`- } else if (behavior === 'exit') {`
	`433`	`+ if (behavior === 'exit') {`
`435`	`434`	`reaction = REACTION_EXIT;`
`436`	`435`	`} else if (behavior === 'log') {`
`437`	`436`	`reaction = REACTION_LOG;`
`438`		`- } else {`
	`437`	`+ } else if (behavior !== 'throw') {`
`439`	`438`	`throw new ERR_MANIFEST_UNKNOWN_ONERROR(behavior);`
`440`	`439`	`}`
`441`	`440`	`}`
`@@ -579,8 +578,7 @@ class Manifest {`
`579`	`578`	`const entry = this.#scopeIntegrities.get(scope);`
`580`	`579`	`if (entry === true) {`
`581`	`580`	`return true;`
`582`		`- } else if (entry === kCascade) {`
`583`		`- } else {`
	`581`	`+ } else if (entry !== kCascade) {`
`584`	`582`	`break;`
`585`	`583`	`}`
`586`	`584`	`}`