fs: move ToNamespacedPath dir calls to c++

anonrig · aduh95 · commit 076e82ca40d9 · 2024-07-16T12:01:18.000+02:00
PR-URL: #53630 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
diff --git a/lib/internal/fs/dir.js b/lib/internal/fs/dir.js
@@ -155,7 +155,7 @@ class Dir {
   readSyncRecursive(dirent) {
     const path = pathModule.join(dirent.parentPath, dirent.name);
     const handle = dirBinding.opendir(
-      pathModule.toNamespacedPath(path),
+      path,
       this.#options.encoding,
     );
 
@@ -298,7 +298,7 @@ function opendir(path, options, callback) {
   req.oncomplete = opendirCallback;
 
   dirBinding.opendir(
-    pathModule.toNamespacedPath(path),
+    path,
     options.encoding,
     req,
   );
@@ -308,9 +308,7 @@ function opendirSync(path, options) {
   path = getValidatedPath(path);
   options = getOptions(options, { encoding: 'utf8' });
 
-  const handle = dirBinding.opendirSync(
-    pathModule.toNamespacedPath(path),
-  );
+  const handle = dirBinding.opendirSync(path);
 
   return new Dir(handle, path, options);
 }
diff --git a/src/node_dir.cc b/src/node_dir.cc
@@ -363,6 +363,7 @@ static void OpenDir(const FunctionCallbackInfo<Value>& args) {
 
   BufferValue path(isolate, args[0]);
   CHECK_NOT_NULL(*path);
+  ToNamespacedPath(env, &path);
 
   const enum encoding encoding = ParseEncoding(isolate, args[1], UTF8);
 
@@ -406,6 +407,7 @@ static void OpenDirSync(const FunctionCallbackInfo<Value>& args) {
 
   BufferValue path(isolate, args[0]);
   CHECK_NOT_NULL(*path);
+  ToNamespacedPath(env, &path);
   THROW_IF_INSUFFICIENT_PERMISSIONS(
       env, permission::PermissionScope::kFileSystemRead, path.ToStringView());
 
