build: fix build warning of c-ares under GN build

zcbenz · marco-ippolito · commit 04798fb104a5 · 2024-08-19T10:32:33.000+02:00
PR-URL: #53750 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
diff --git a/deps/cares/unofficial.gni b/deps/cares/unofficial.gni
@@ -65,11 +65,17 @@ template("cares_gn_build") {
       sources += gypi_values.cares_sources_mac
     }
 
-    if (is_clang || !is_win) {
-      cflags_c = [
-        "-Wno-implicit-fallthrough",
-        "-Wno-unreachable-code",
-      ]
+    if (is_clang) {
+      if (is_win) {
+        cflags_c = [
+          "-Wno-macro-redefined",
+        ]
+      } else {
+        cflags_c = [
+          "-Wno-implicit-fallthrough",
+          "-Wno-unreachable-code",
+        ]
+      }
     }
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -65,11 +65,17 @@ template("cares_gn_build") {`
`65`	`65`	`sources += gypi_values.cares_sources_mac`
`66`	`66`	`}`
`67`	`67`
`68`		`- if (is_clang \|\| !is_win) {`
`69`		`- cflags_c = [`
`70`		`- "-Wno-implicit-fallthrough",`
`71`		`- "-Wno-unreachable-code",`
`72`		`- ]`
	`68`	`+ if (is_clang) {`
	`69`	`+ if (is_win) {`
	`70`	`+ cflags_c = [`
	`71`	`+ "-Wno-macro-redefined",`
	`72`	`+ ]`
	`73`	`+ } else {`
	`74`	`+ cflags_c = [`
	`75`	`+ "-Wno-implicit-fallthrough",`
	`76`	`+ "-Wno-unreachable-code",`
	`77`	`+ ]`
	`78`	`+ }`
`73`	`79`	`}`
`74`	`80`	`}`
`75`	`81`	`}`