test: remove `require('buffer')` from 4 test files · nodejs/node@005e343 · GitHub
Skip to content

Commit 005e343

Browse files
XadillaXaddaleax
authored andcommitted
test: remove require('buffer') from 4 test files
We don't use the global Buffer throughout the lib/ to avoid circular dependency issues in core, but we actually don't need to require it on test files. So remove them on: + test/parallel/test-stream-uint8array.js + test/parallel/test-stream2-finish-pipe.js + test/parallel/test-tls-session-cache.js + test/parallel/test-vm-cached-data.js Refs: #13836 PR-URL: #13844 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
1 parent df3c292 commit 005e343

4 files changed

Lines changed: 0 additions & 4 deletions

File tree

test/parallel/test-stream-uint8array.js

Lines changed: 0 additions & 1 deletion

test/parallel/test-stream2-finish-pipe.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
'use strict';
2323
require('../common');
2424
const stream = require('stream');
25-
const Buffer = require('buffer').Buffer;
2625

2726
const r = new stream.Readable();
2827
r._read = function(size) {

test/parallel/test-tls-session-cache.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ function doTest(testOptions, callback) {
4646
const fs = require('fs');
4747
const join = require('path').join;
4848
const spawn = require('child_process').spawn;
49-
const Buffer = require('buffer').Buffer;
5049

5150
const keyFile = join(common.fixturesDir, 'agent.key');
5251
const certFile = join(common.fixturesDir, 'agent.crt');

test/parallel/test-vm-cached-data.js

Lines changed: 0 additions & 1 deletion

0 commit comments

Comments
 (0)