src: fix some warnings and erroneous PRINT_DEBUG

mmarchini · mmarchini · commit 364e0346863c · 2020-03-30T15:24:18.000-07:00
PR-URL: #354 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
diff --git a/src/constants.cc b/src/constants.cc
@@ -85,7 +85,7 @@ int64_t Constants::LoadConstant(const char* name, int64_t def) {
   auto constant =
       Constants::LookupConstant(target_, (constant_prefix() + name).c_str());
   if (!constant.Check()) {
-    PRINT_DEBUG("Failed to load constant %s, default to %" PRId64, name);
+    PRINT_DEBUG("Failed to load constant %s, default to %" PRId64, name, def);
     return def;
   }
 
diff --git a/src/error.cc b/src/error.cc
@@ -22,7 +22,7 @@ void Error::PrintInDebugMode(const char* file, int line, const char* funcname,
     return;
   }
   char fmt[kMaxMessageLength];
-  snprintf(fmt, sizeof(fmt), "[llnode][%s %s:%lld] %s\n", funcname, file, line,
+  snprintf(fmt, sizeof(fmt), "[llnode][%s %s:%d] %s\n", funcname, file, line,
            format);
   va_list arglist;
   va_start(arglist, format);

Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,7 @@ int64_t Constants::LoadConstant(const char* name, int64_t def) {`
`85`	`85`	`auto constant =`
`86`	`86`	`Constants::LookupConstant(target_, (constant_prefix() + name).c_str());`
`87`	`87`	`if (!constant.Check()) {`
`88`		`- PRINT_DEBUG("Failed to load constant %s, default to %" PRId64, name);`
	`88`	`+ PRINT_DEBUG("Failed to load constant %s, default to %" PRId64, name, def);`
`89`	`89`	`return def;`
`90`	`90`	`}`
`91`	`91`
Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ void Error::PrintInDebugMode(const char* file, int line, const char* funcname,`
`22`	`22`	`return;`
`23`	`23`	`}`
`24`	`24`	`char fmt[kMaxMessageLength];`
`25`		`- snprintf(fmt, sizeof(fmt), "[llnode][%s %s:%lld] %s\n", funcname, file, line,`
	`25`	`+ snprintf(fmt, sizeof(fmt), "[llnode][%s %s:%d] %s\n", funcname, file, line,`
`26`	`26`	`format);`
`27`	`27`	`va_list arglist;`
`28`	`28`	`va_start(arglist, format);`