test: add missing crypto checks by jbergstroem · Pull Request #2129 · nodejs/node · GitHub
Skip to content

test: add missing crypto checks#2129

Closed
jbergstroem wants to merge 1 commit into
nodejs:masterfrom
jbergstroem:fix/missing-crypto-checks
Closed

test: add missing crypto checks#2129
jbergstroem wants to merge 1 commit into
nodejs:masterfrom
jbergstroem:fix/missing-crypto-checks

Conversation

@jbergstroem

Copy link
Copy Markdown
Member

Add a check for crypto before using it, similar to how other tests work.

Guess my previous commit ("Refactor all tests that depends on crypto", 671fbd5) wasn't accurate 🐼

/R=@shigeki? (you reviewed last time)

Add a check for crypto before using it, similar to how
other tests work.
@shigeki

shigeki commented Jul 8, 2015

Copy link
Copy Markdown
Contributor

@Fishrock123

Copy link
Copy Markdown
Contributor

LGTM

@Fishrock123 Fishrock123 added the test Issues and PRs related to the tests. label Jul 8, 2015
jbergstroem added a commit that referenced this pull request Jul 8, 2015
Add a check for crypto before using it, similar to how
other tests work.

PR-URL: #2129
Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@jbergstroem

Copy link
Copy Markdown
Member Author

@jbergstroem jbergstroem closed this Jul 8, 2015
mscdex pushed a commit to mscdex/io.js that referenced this pull request Jul 9, 2015
Add a check for crypto before using it, similar to how
other tests work.

PR-URL: nodejs#2129
Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants