vm: remove unnecessary access checks

domenic · rvagg · commit 222c8a53cf0e · 2015-07-22T18:45:31.000+10:00
No reason to install access checks if they're always going to return true. PR-URL: #1773 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
diff --git a/src/node_contextify.cc b/src/node_contextify.cc
@@ -208,8 +208,6 @@ class ContextifyContext {
                                              GlobalPropertyDeleterCallback,
                                              GlobalPropertyEnumeratorCallback,
                                              CreateDataWrapper(env));
-    object_template->SetAccessCheckCallbacks(GlobalPropertyNamedAccessCheck,
-                                             GlobalPropertyIndexedAccessCheck);
 
     Local<Context> ctx = Context::New(env->isolate(), nullptr, object_template);
     if (!ctx.IsEmpty())
@@ -343,22 +341,6 @@ class ContextifyContext {
   }
 
 
-  static bool GlobalPropertyNamedAccessCheck(Local<Object> host,
-                                             Local<Value> key,
-                                             AccessType type,
-                                             Local<Value> data) {
-    return true;
-  }
-
-
-  static bool GlobalPropertyIndexedAccessCheck(Local<Object> host,
-                                               uint32_t key,
-                                               AccessType type,
-                                               Local<Value> data) {
-    return true;
-  }
-
-
   static void GlobalPropertyGetterCallback(
       Local<String> property,
       const PropertyCallbackInfo<Value>& args) {
